[ 
https://issues.apache.org/jira/browse/MWRAPPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506138#comment-17506138
 ] 

Jorge Solórzano commented on MWRAPPER-59:
-----------------------------------------

I'm not sure if it's a good idea to inline the source of 
MavenWrapperDownloader.java, the only advantage I see is to remove the `source` 
installing type which I don't see as an issue. 

> Inline MavenWrapperDownloader.java into mvnw
> --------------------------------------------
>
>                 Key: MWRAPPER-59
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-59
>             Project: Maven Wrapper
>          Issue Type: Improvement
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.0
>            Reporter: James Z.M. Gao
>            Priority: Major
>
> by inlining a lean version of MavenWrapperDownloader.java into `mnvw` script, 
> we can remove the `source`  installing type, and avoid reuse an outdated 
> MavenWrapperDownloader.class



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to