jorsol commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1067038041
> mavenUserHome is more like a maven directory for [user configuration](https://github.com/apache/maven/blob/maven-3.8.5/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L133), and expected to work as maven. It's not only for user configuration, it's also used for `maven.repo.local` (the repository on the local machine), that BTW can also be configured. By removing this you are making it fixed into `~/.m2` and that already contradicts your perception of user configuration. The "naming" of `maven.user.home` might or might not be correct, that could be debated, it was borrowed from [gradle](https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home) and the previous wrapper was already using it. I honestly don't mind if it's renamed to something like `maven.distro.basedir`, and it should be properly documented, but just removing this without replacement doesn't sounds like a good plan. Anyway, the final word should come from a Maven maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
