[GitHub] [lucene-solr] aroopganguly closed pull request #1335: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method

2020-03-11 Thread GitBox
aroopganguly closed pull request #1335: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method URL: https://github.com/apache/lucene-solr/pull/1335 This is an automated message f

[GitHub] [lucene-solr] aroopganguly edited a comment on issue #1344: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() squashed

2020-03-11 Thread GitBox
aroopganguly edited a comment on issue #1344: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() squashed URL: https://github.com/apache/lucene-solr/pull/1344#issuecomment-597818362 @tflobbe @anshumg @noblepaul This is a squashed version of

[GitHub] [lucene-solr] dsmiley commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-11 Thread GitBox
dsmiley commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#issuecomment-597830616 BTW thanks for your contributions lately. Perhaps you will be at Berlin Buzzwords this June; I shall be there

[GitHub] [lucene-solr] dsmiley closed pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-03-11 Thread GitBox
dsmiley closed pull request #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] dsmiley commented on issue #1332: SOLR-14254: Docs for text tagger: FST50 trade-off

2020-03-11 Thread GitBox
dsmiley commented on issue #1332: SOLR-14254: Docs for text tagger: FST50 trade-off URL: https://github.com/apache/lucene-solr/pull/1332#issuecomment-597978433 I thought it'd be good to add a solr-upgrade-notes warning too, both in 8.4 and 8.5 -

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-12 Thread GitBox
mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r391504306 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-12 Thread GitBox
dweiss commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r391523979 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-12 Thread GitBox
mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r391547313 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-12 Thread GitBox
dweiss commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r391552531 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] jimczi commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-12 Thread GitBox
jimczi commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#issuecomment-598150417 Thanks for the ping @msokolov . > if you can comment on whether the MaxScoreAccumulator still p

[GitHub] [lucene-solr] iverase opened a new pull request #1345: make TestLatLonMultiPolygonShapeQueries more resilient for CONTAINS queries

2020-03-12 Thread GitBox
iverase opened a new pull request #1345: make TestLatLonMultiPolygonShapeQueries more resilient for CONTAINS queries URL: https://github.com/apache/lucene-solr/pull/1345 This test can fail when a circle goes over the pole as distance point to line can have quite a bit of error.

[GitHub] [lucene-solr] magibney commented on issue #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation

2020-03-12 Thread GitBox
magibney commented on issue #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation URL: https://github.com/apache/lucene-solr/pull/751#issuecomment-598193540 Force push of bc4b18f separates into two logical commits: one introduces

[GitHub] [lucene-solr] tflobbe merged pull request #1344: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() squashed

2020-03-12 Thread GitBox
tflobbe merged pull request #1344: SOLR-14316 Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() squashed URL: https://github.com/apache/lucene-solr/pull/1344 This is an automated message from

[GitHub] [lucene-solr] sigram commented on a change in pull request #1329: SOLR-14275: Policy calculations are very slow for large clusters and large operations

2020-03-12 Thread GitBox
sigram commented on a change in pull request #1329: SOLR-14275: Policy calculations are very slow for large clusters and large operations URL: https://github.com/apache/lucene-solr/pull/1329#discussion_r391797970 ## File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/In

[GitHub] [lucene-solr] s1monw opened a new pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-12 Thread GitBox
s1monw opened a new pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346 Today we have a large amount of duplicated code that is rather of complex nature. This change consolidates the code-paths to

[GitHub] [lucene-solr] s1monw commented on issue #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-12 Thread GitBox
s1monw commented on issue #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#issuecomment-598351277 @mikemccand @dnhatn wanna take a look This is

[GitHub] [lucene-solr] s1monw commented on issue #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-12 Thread GitBox
s1monw commented on issue #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#issuecomment-598371903 @uschindler I would love to get your input here too --

[GitHub] [lucene-solr] madrob opened a new pull request #1347: SOLR-14322 Improve AbstractFullDistribZkTestBase.waitForThingsToLevelOut

2020-03-12 Thread GitBox
madrob opened a new pull request #1347: SOLR-14322 Improve AbstractFullDistribZkTestBase.waitForThingsToLevelOut URL: https://github.com/apache/lucene-solr/pull/1347 https://issues.apache.org/jira/browse/SOLR-14322 This is an

[GitHub] [lucene-solr] madrob commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary

2020-03-12 Thread GitBox
madrob commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary URL: https://github.com/apache/lucene-solr/pull/1298#discussion_r391898475 ## File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java ## @@ -285,7 +2

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary

2020-03-12 Thread GitBox
dsmiley commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary URL: https://github.com/apache/lucene-solr/pull/1298#discussion_r391985435 ## File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java ## @@ -285,7 +

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-12 Thread GitBox
dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392011485 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-12 Thread GitBox
dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392011697 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392044537 ## File path: solr/core/src/test/org/apache/solr/handler/component/DistributedExpandComponent

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392042877 ## File path: solr/CHANGES.txt ## @@ -114,6 +114,8 @@ Improvements * SOLR-13965: In

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392044626 ## File path: solr/core/src/test/org/apache/solr/handler/component/TestExpandComponent.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392043206 ## File path: solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392043916 ## File path: solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-12 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392043974 ## File path: solr/core/src/java/org/apache/solr/search/DocSlice.java ## @@ -56,7 +5

[GitHub] [lucene-solr] micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#issuecomment-598668787 Thank you for your time and help! Fwiw, I appreciate it a lot. I'll be to Buzzwords too, hoping it's actuall

[GitHub] [lucene-solr] micpalmia edited a comment on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
micpalmia edited a comment on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#issuecomment-598668787 Thank you for your time and help! Fwiw, I appreciate it a lot. I'll be at Buzzwords too, hoping it's

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r39264 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392228458 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource

[GitHub] [lucene-solr] madrob commented on issue #1298: SOLR-14289 Skip ZkChroot check when not necessary

2020-03-13 Thread GitBox
madrob commented on issue #1298: SOLR-14289 Skip ZkChroot check when not necessary URL: https://github.com/apache/lucene-solr/pull/1298#issuecomment-598756692 Switched to a boolean, and rebased to account for SOLR-14197 changes --

[GitHub] [lucene-solr] CBWallaby opened a new pull request #1348: SOLR-14326 Number of tlog replicas off by one when restoring collections

2020-03-13 Thread GitBox
CBWallaby opened a new pull request #1348: SOLR-14326 Number of tlog replicas off by one when restoring collections URL: https://github.com/apache/lucene-solr/pull/1348 https://issues.apache.org/jira/browse/SOLR-14326 When making a request to restore a collection, the quantity of tlo

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392367810 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392381180 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392379518 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392387868 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-13 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392383623 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-13 Thread GitBox
dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392396808 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java

[GitHub] [lucene-solr] madrob merged pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary

2020-03-13 Thread GitBox
madrob merged pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary URL: https://github.com/apache/lucene-solr/pull/1298 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-solr] s1monw merged pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument

2020-03-13 Thread GitBox
s1monw merged pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346 This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] gerlowskija opened a new pull request #1349: Document sort param tiebreak logic

2020-03-13 Thread GitBox
gerlowskija opened a new pull request #1349: Document sort param tiebreak logic URL: https://github.com/apache/lucene-solr/pull/1349 # Description I was trying to explain Solr's not-completely-deterministic `sort` param resolution to a coworker this week, and realized that this behav

[GitHub] [lucene-solr] s1monw opened a new pull request #1350: Cleanup DWPT for readability

2020-03-13 Thread GitBox
s1monw opened a new pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350 DWPT had some complicated logic to account for failures etc. This change cleans up this logic and simplifies the document processing loop.

[GitHub] [lucene-solr] s1monw commented on issue #1350: Cleanup DWPT for readability

2020-03-13 Thread GitBox
s1monw commented on issue #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#issuecomment-598890923 @dnhatn wanna take a look? This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1351: Collectors to skip noncompetitive documents

2020-03-13 Thread GitBox
mayya-sharipova opened a new pull request #1351: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351 Similar how scorers can update their iterators to skip non-competitive documents, collectors and comparators should also provide and update

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: Collectors to skip noncompetitive documents

2020-03-13 Thread GitBox
mayya-sharipova commented on issue #1351: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-598953853 @jimczi I have created a draft PR for comparators and collectors to skip non-competitive docs. Can you please have a look at it

[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls

2020-03-13 Thread GitBox
andyvuong commented on a change in pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls URL: https://github.com/apache/lucene-solr/pull/1317#discussion_r392544473 ## File path: solr/core/src/java/org/apache/solr/store/shared/metadata/S

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls

2020-03-13 Thread GitBox
mbwaheed commented on a change in pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls URL: https://github.com/apache/lucene-solr/pull/1317#discussion_r392545214 ## File path: solr/core/src/test/org/apache/solr/store/shared/metadata/Sh

[GitHub] [lucene-solr] dsmiley merged pull request #1332: SOLR-14254: Docs for text tagger: FST50 trade-off

2020-03-13 Thread GitBox
dsmiley merged pull request #1332: SOLR-14254: Docs for text tagger: FST50 trade-off URL: https://github.com/apache/lucene-solr/pull/1332 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-solr] mocobeta opened a new pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-13 Thread GitBox
mocobeta opened a new pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352 # Description See https://issues.apache.org/jira/browse/LUCENE-9278 --

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-13 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392562400 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // ge

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-13 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392562835 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ config

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392562835 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ config

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392568557 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.jav

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568691 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // gene

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568764 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ configur

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
dweiss commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392568830 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // gene

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392569098 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesour

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392569092 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesour

[GitHub] [lucene-solr] micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
micpalmia commented on issue #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#issuecomment-599032031 > No auto-boxing concerns for Boolean :-) thanks for the reassurance :) - do you mean the performance

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392571884 ## File path: gradle/render-javadoc.gradle ## @@ -294,35 +305,41 @@ config

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path

2020-03-14 Thread GitBox
mocobeta commented on a change in pull request #1352: LUCENE-9278: Make javadoc folder structure follow Gradle project path URL: https://github.com/apache/lucene-solr/pull/1352#discussion_r392571898 ## File path: gradle/render-javadoc.gradle ## @@ -17,11 +17,15 @@ // ge

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589684 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -318,8 +301,10 @@ priv

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589649 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -249,34 +247,19 @@ pub

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability

2020-03-14 Thread GitBox
dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589684 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ## @@ -318,8 +301,10 @@ priv

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-14 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392594785 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java

[GitHub] [lucene-solr] arysin opened a new pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin opened a new pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353 # Description Please provide a short description of the changes you're making with this pull request. # Solut

[GitHub] [lucene-solr] arysin closed pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin closed pull request #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] arysin commented on issue #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-14 Thread GitBox
arysin commented on issue #1353: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1353#issuecomment-599153969 Looks like needs a bit more work This is an automated

[GitHub] [lucene-solr] kaynewu commented on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput

2020-03-15 Thread GitBox
kaynewu commented on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput URL: https://github.com/apache/lucene-solr/pull/1143#issuecomment-599191196 > @kaynewu Have you opened a JIRA issue as well for this? sorry for the late reply, I have opened a JIRA for this problem,Pl

[GitHub] [lucene-solr] kaynewu edited a comment on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput

2020-03-15 Thread GitBox
kaynewu edited a comment on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput URL: https://github.com/apache/lucene-solr/pull/1143#issuecomment-599191196 > @kaynewu Have you opened a JIRA issue as well for this? @janhoy Sorry for the late reply, I have opened a JIRA for

[GitHub] [lucene-solr] kaynewu edited a comment on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput

2020-03-15 Thread GitBox
kaynewu edited a comment on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput URL: https://github.com/apache/lucene-solr/pull/1143#issuecomment-599191196 > @kaynewu Have you opened a JIRA issue as well for this? @janhoy Sorry for the late reply, I have opened a JIRA for

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-15 Thread GitBox
dsmiley commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392676630 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource

[GitHub] [lucene-solr] micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-15 Thread GitBox
micpalmia commented on a change in pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343#discussion_r392677444 ## File path: lucene/queries/src/java/org/apache/lucene/queries/function/valuesour

[GitHub] [lucene-solr] dsmiley closed pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource

2020-03-15 Thread GitBox
dsmiley closed pull request #1343: LUCENE-8103: Use two-phase iteration in Query- and DoubleValuesSource URL: https://github.com/apache/lucene-solr/pull/1343 This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] arysin opened a new pull request #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-15 Thread GitBox
arysin opened a new pull request #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1354 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] dweiss commented on issue #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-15 Thread GitBox
dweiss commented on issue #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1354#issuecomment-599265729 Looks good to me, thanks Andriy! This is an automated

[GitHub] [lucene-solr] dweiss merged pull request #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-15 Thread GitBox
dweiss merged pull request #1354: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1354 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] msokolov commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score

2020-03-16 Thread GitBox
msokolov commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#issuecomment-599479702 > I think it would be preferrable to specialize at this point. What do you think ? I tried th

[GitHub] [lucene-solr] gerlowskija merged pull request #1349: Document sort param tiebreak logic

2020-03-16 Thread GitBox
gerlowskija merged pull request #1349: Document sort param tiebreak logic URL: https://github.com/apache/lucene-solr/pull/1349 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] uschindler commented on issue #1349: Document sort param tiebreak logic

2020-03-16 Thread GitBox
uschindler commented on issue #1349: Document sort param tiebreak logic URL: https://github.com/apache/lucene-solr/pull/1349#issuecomment-599503010 This is specially important for search-after cursors, so maybe we should mention this, too! --

[GitHub] [lucene-solr] arysin opened a new pull request #1355: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-16 Thread GitBox
arysin opened a new pull request #1355: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1355 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] arysin opened a new pull request #1356: LUCENE-9279: Update dictionary version for Ukrainian analyzer

2020-03-16 Thread GitBox
arysin opened a new pull request #1356: LUCENE-9279: Update dictionary version for Ukrainian analyzer URL: https://github.com/apache/lucene-solr/pull/1356 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] gerlowskija commented on issue #1349: Document sort param tiebreak logic

2020-03-16 Thread GitBox
gerlowskija commented on issue #1349: Document sort param tiebreak logic URL: https://github.com/apache/lucene-solr/pull/1349#issuecomment-599572742 I can imagine how this would be an issue in that context but I haven't seen it specifically so I'm a little leery of drafting language that mi

[GitHub] [lucene-solr] risdenk commented on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput

2020-03-16 Thread GitBox
risdenk commented on issue #1143: SOLR-14328:HdfsDirectory support createTempOutput URL: https://github.com/apache/lucene-solr/pull/1143#issuecomment-599574140 @kaynewu I think this was already resolved in SOLR-14242? It was fixed around around the same time this PR was opened. -

[GitHub] [lucene-solr] ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393101862 ## File path: solr/core/src/test/org/apache/solr/handler/component/DistributedExpandComp

[GitHub] [lucene-solr] ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393101812 ## File path: solr/core/src/test/org/apache/solr/handler/component/TestExpandComponent.j

[GitHub] [lucene-solr] ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393111927 ## File path: solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393126595 ## File path: solr/solr-ref-guide/src/collapse-and-expand-results.adoc ## @@ -142,6

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393125271 ## File path: solr/CHANGES.txt ## @@ -57,7 +57,7 @@ Improvements Optimizations -

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393132417 ## File path: solr/solr-ref-guide/src/collapse-and-expand-results.adoc ## @@ -142,6

[GitHub] [lucene-solr] ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393158074 ## File path: solr/CHANGES.txt ## @@ -57,7 +57,7 @@ Improvements Optimizatio

[GitHub] [lucene-solr] ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0

2020-03-16 Thread GitBox
ameliahenderson commented on a change in pull request #1334: SOLR-8306: Enhance ExpandComponent to allow expand.hits=0 URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r393158282 ## File path: solr/solr-ref-guide/src/collapse-and-expand-results.adoc ## @@ -1

[GitHub] [lucene-solr] andyvuong commented on issue #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls

2020-03-16 Thread GitBox
andyvuong commented on issue #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls URL: https://github.com/apache/lucene-solr/pull/1317#issuecomment-599655907 cc @yonik This is an automated m

[GitHub] [lucene-solr] yonik merged pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls

2020-03-16 Thread GitBox
yonik merged pull request #1317: SOLR-13101: Create metadataSuffix znode only at common shard creating api calls URL: https://github.com/apache/lucene-solr/pull/1317 This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] magibney opened a new pull request #1357: SOLR-13807: Introduce a cache for term facet counts

2020-03-16 Thread GitBox
magibney opened a new pull request #1357: SOLR-13807: Introduce a cache for term facet counts URL: https://github.com/apache/lucene-solr/pull/1357 See issue [SOLR-13807](https://issues.apache.org/jira/browse/SOLR-13807). The latter of the two commits pushed here is the one associated with

<    5   6   7   8   9   10   11   12   13   14   >