dsmiley commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot
check when not necessary
URL: https://github.com/apache/lucene-solr/pull/1298#discussion_r391985435
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##########
@@ -285,7 +285,7 @@ public static NodeConfig loadNodeConfig(Path solrHome,
Properties nodeProperties
if (zkClient.exists("/solr.xml", true)) {
log.info("solr.xml found in ZooKeeper. Loading...");
byte[] data = zkClient.getData("/solr.xml", null, null, true);
- return SolrXmlConfig.fromInputStream(loader, new
ByteArrayInputStream(data));
+ return SolrXmlConfig.fromInputStream(loader, new
ByteArrayInputStream(data), "zookeeper");
Review comment:
Then I much prefer a boolean as it'd be much clearer -- "isInZooKeeper" or
some-such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
