msokolov commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#issuecomment-599479702 > I think it would be preferrable to specialize at this point. What do you think ? I tried this out, and although there is some duplication, it is much easier to read now - thanks for the idea! I also found a bunch of edge cases while doing some deeper testing, and cleaned up the code in IndexSearcher that creates the collector managers. Performance improvements are basically unchanged; maybe a bit better. I'll post numbers in the JIRA.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
