dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392396808
########## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ########## @@ -1655,7 +1655,7 @@ private long updateDocument(final DocumentsWriterDeleteQueue.Node<?> delNode, ensureOpen(); boolean success = false; try { - final long seqNo = maybeProcessEvents(docWriter.updateDocument(doc, analyzer, delNode)); + final long seqNo = maybeProcessEvents(docWriter.updateDocuments(List.of(doc), analyzer, delNode)); Review comment: Can we just delegate this method to `IndexWriter#updateDocuments`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org