dnhatn commented on a change in pull request #1350: Cleanup DWPT for readability
URL: https://github.com/apache/lucene-solr/pull/1350#discussion_r392589684
##########
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##########
@@ -318,8 +301,10 @@ private long
finishDocuments(DocumentsWriterDeleteQueue.Node<?> deleteNode, int
// Buffer a specific docID for deletion. Currently only
// used when we hit an exception when adding a document
- void deleteDocID(int docIDUpto) {
- pendingUpdates.addDocID(docIDUpto);
+ private void deleteLastDocs(int docCount) {
Review comment:
Can you update the javadocs (it's a bit stale: `a specific docID`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
