dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same 
code-path for updateDocuments and updateDocument
URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392011697
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java
 ##########
 @@ -474,49 +474,11 @@ long updateDocuments(final Iterable<? extends Iterable<? 
extends IndexableField>
     return seqNo;
   }
 
+
   long updateDocument(final Iterable<? extends IndexableField> doc, final 
Analyzer analyzer,
 
 Review comment:
   Can we also remove this method and delegate `updateDocument` to 
`updateDocuments` in IndexWriter instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to