madrob commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot
check when not necessary
URL: https://github.com/apache/lucene-solr/pull/1298#discussion_r391898475
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##########
@@ -285,7 +285,7 @@ public static NodeConfig loadNodeConfig(Path solrHome,
Properties nodeProperties
if (zkClient.exists("/solr.xml", true)) {
log.info("solr.xml found in ZooKeeper. Loading...");
byte[] data = zkClient.getData("/solr.xml", null, null, true);
- return SolrXmlConfig.fromInputStream(loader, new
ByteArrayInputStream(data));
+ return SolrXmlConfig.fromInputStream(loader, new
ByteArrayInputStream(data), "zookeeper");
Review comment:
Yea, a boolean would be sufficient. I was thinking about if we need to have
other sources in the future, but we can change this to a string/enum later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
