shubhamvishu commented on code in PR #12868:
URL: https://github.com/apache/lucene/pull/12868#discussion_r1414510733
##
lucene/codecs/src/java/org/apache/lucene/codecs/bloom/FuzzySet.java:
##
@@ -150,9 +150,10 @@ private FuzzySet(FixedBitSet filter, int bloomSize, int
hashCount
dungba88 commented on PR #12831:
URL: https://github.com/apache/lucene/pull/12831#issuecomment-1840269923
I'll put the CHANGES.txt for #12624 together with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jpountz closed issue #10375: Add a bulk scorer for disjunctions that does
dynamic pruning [LUCENE-9335]
URL: https://github.com/apache/lucene/issues/10375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jpountz commented on issue #10375:
URL: https://github.com/apache/lucene/issues/10375#issuecomment-1840276633
Implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jpountz opened a new issue, #12877:
URL: https://github.com/apache/lucene/issues/12877
### Description
We have an issue about decoupling search concurrency from index geometry
(#9721), but this comes with trade-offs as the per-segment bit of search is
hard to parallelize. Maybe we sh
dungba88 commented on code in PR #12844:
URL: https://github.com/apache/lucene/pull/12844#discussion_r1415164737
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java:
##
@@ -351,7 +351,8 @@ public int[] getBulkOrdinals(FacetLabel... ca
s1monw commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1415196168
##
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java:
##
@@ -262,6 +277,73 @@ long updateDocuments(
}
}
+ private interface DocValid
jpountz commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1415213374
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java:
##
@@ -212,6 +213,46 @@ public long readLong() throws IOException {
}
}
+ @Overri
jpountz commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1415234949
##
lucene/core/src/java/org/apache/lucene/store/DataOutput.java:
##
@@ -324,4 +326,42 @@ public void writeSetOfStrings(Set set) throws
IOException {
writeStrin
uschindler merged PR #12873:
URL: https://github.com/apache/lucene/pull/12873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler closed issue #8933: Maybe expression compiler should cache recently
compiled expressions? [LUCENE-7882]
URL: https://github.com/apache/lucene/issues/8933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uschindler commented on issue #8933:
URL: https://github.com/apache/lucene/issues/8933#issuecomment-1840518911
The new code also fixes the problem with hidden stack frames caused by
hidden class feature.
I am still hoping to have an option in future to turn on some stack frames
like
mikemccand commented on code in PR #12345:
URL: https://github.com/apache/lucene/pull/12345#discussion_r1415450166
##
lucene/core/src/java/org/apache/lucene/index/ExitableIndexReader.java:
##
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mikemccand commented on PR #12624:
URL: https://github.com/apache/lucene/pull/12624#issuecomment-1840646081
> > I tested just how much slower the ByteBuffer based store is than the
FST's BytesStore:
>
> I assume this is before the last iteration that does the freeze, is that
right? W
mikemccand commented on issue #12852:
URL: https://github.com/apache/lucene/issues/12852#issuecomment-1840648672
At least we should add a warning to the javadocs here.
And we should audit other places that are frequently calling
`.toDataInput()` (e.g. block tree terms dict writing?).
shubhamvishu commented on code in PR #12868:
URL: https://github.com/apache/lucene/pull/12868#discussion_r1415528939
##
lucene/codecs/src/java/org/apache/lucene/codecs/bloom/FuzzySet.java:
##
@@ -150,9 +150,10 @@ private FuzzySet(FixedBitSet filter, int bloomSize, int
hashCount
mikemccand commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415505550
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -153,6 +180,40 @@ private FSTCompiler(
}
}
+ // Get the respective FSTReader o
mikemccand commented on PR #587:
URL: https://github.com/apache/lucene/pull/587#issuecomment-1840761468
@zacharymorn given that it's been so long, and we are unlikely to release
another 9.0.x bugfix release, I think we should close this. The fix is present
in Lucene 9.1.0 and above.
--
mikemccand closed pull request #587: LUCENE-10236: Update field-weight used in
CombinedFieldQuery scoring calculation (9.0.1 Backporting)
URL: https://github.com/apache/lucene/pull/587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mikemccand commented on PR #12829:
URL: https://github.com/apache/lucene/pull/12829#issuecomment-1840782006
Thanks @s1monw -- I'll try to review soon.
> The only think I am torn on is, if we set the num of children as a value
for the DV field then I guess we should have a good usecase
jpountz commented on code in PR #12868:
URL: https://github.com/apache/lucene/pull/12868#discussion_r1415603528
##
lucene/codecs/src/java/org/apache/lucene/codecs/bloom/FuzzySet.java:
##
@@ -150,9 +150,10 @@ private FuzzySet(FixedBitSet filter, int bloomSize, int
hashCount) {
dweiss commented on issue #12852:
URL: https://github.com/apache/lucene/issues/12852#issuecomment-1840786092
I don't think it was ever meant to be called repeatedly in fast bursts. It
was meant to provide a direct reader for previously written buffers, once the
writing is completed.
--
T
dweiss commented on issue #12852:
URL: https://github.com/apache/lucene/issues/12852#issuecomment-1840793857
Also, not sure why it's slow - perhaps because of the wrapping in read-only
buffers when toBufferList is called? If so, then this could be internally
tweaked by calling toWriteableBu
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415625009
##
lucene/core/src/test/org/apache/lucene/util/fst/TestFSTDataOutputWriter.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415627354
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mikemccand commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1415586966
##
lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java:
##
@@ -1678,6 +1678,51 @@ public void testIllegalIndexSortChange2() throws
Exception {
IO
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415627354
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415641634
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -500,6 +502,12 @@ public FSTMetadata getMetadata() {
return metadata;
}
+ /**
+ * Save
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415666711
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -218,13 +279,19 @@ public Builder allowFixedLengthArcs(boolean
allowFixedLengthArcs) {
easyice commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1415479977
##
lucene/core/src/java/org/apache/lucene/store/DataOutput.java:
##
@@ -324,4 +326,42 @@ public void writeSetOfStrings(Set set) throws
IOException {
writeStrin
rmuir commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1840885611
> Thank you very much for your suggestions, i had fixed the comments from
@jpountz, but the related to Mmapdir will be later(such as java19, java20
support), because we need to confirm whe
uschindler opened a new pull request, #12878:
URL: https://github.com/apache/lucene/pull/12878
This PR fixes the issue found while coding the benchmark of Expressions
module in #12873: The expressions module looks up the variables using the
`DoubleValues#doubleValue` method, which throws `I
jimczi commented on PR #12551:
URL: https://github.com/apache/lucene/pull/12551#issuecomment-1841063019
Superseded by https://github.com/apache/lucene/pull/12794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jimczi closed pull request #12551: Introduce dynamic segment efSearch to
Knn{Byte|Float}VectorQuery
URL: https://github.com/apache/lucene/pull/12551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415869383
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -120,22 +125,44 @@ public class FSTCompiler {
final float directAddressingMaxOversizingF
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415871453
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/fst/FSTTester.java:
##
@@ -316,6 +313,15 @@ public FST doTest() throws IOException {
return fst;
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1415876855
##
lucene/core/src/test/org/apache/lucene/util/fst/Test2BFSTOffHeap.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
easyice commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1841102583
Thank you @rmuir, the new assembly output is here:) CC @uschindler
https://github.com/easyice/lucene_files/blob/main/MemorySegmentIndexInput.readGroupVInt.asm.txt
--
This
uschindler commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1841347419
Hi,
Did you create this one with the jmh option `-perfasm`? This looks like
unoptimized code generated only by C1, not by the C2 compiler.
It would be good to have 2 asm dump
uschindler commented on PR #12878:
URL: https://github.com/apache/lucene/pull/12878#issuecomment-1841418704
> LGTM. I think an explicit IOException is better than wrapping in
UncheckedIOException.
The UncheckedIOException was just a workaround when I implemented the
benchmark code. W
uschindler commented on code in PR #12878:
URL: https://github.com/apache/lucene/pull/12878#discussion_r1416143382
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/ExpressionsBenchmark.java:
##
@@ -83,12 +82,8 @@ private static double ident(double v) {
private
dweiss commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1416181846
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
uschindler commented on PR #12873:
URL: https://github.com/apache/lucene/pull/12873#issuecomment-1841494970
> While writing the benchmark I figured out that the Expression base class
has some problems with a missing `IOException` on the
`evaluate(DoubleValues[])` method. As bytecode knows n
gsmiller commented on PR #12837:
URL: https://github.com/apache/lucene/pull/12837#issuecomment-1841521890
I think what you said sounds right @slow-J. Having another look at this and
the associated bp PR today. Thanks!
--
This is an automated message from the Apache Git Service.
To respond
gsmiller commented on code in PR #12864:
URL: https://github.com/apache/lucene/pull/12864#discussion_r1416215309
##
lucene/CHANGES.txt:
##
@@ -7,7 +7,8 @@ http://s.apache.org/luceneversions
API Changes
-
-(No changes)
+* GITHUB#12243: Mark TermInSetQuery
gsmiller commented on code in PR #12837:
URL: https://github.com/apache/lucene/pull/12837#discussion_r1416221972
##
lucene/CHANGES.txt:
##
@@ -67,6 +67,8 @@ API Changes
* GITHUB#11023: Adding -level param to CheckIndex, making the old -fast param
the default behaviour. (Jaku
slow-J commented on PR #12864:
URL: https://github.com/apache/lucene/pull/12864#issuecomment-1841640724
> Mark TermInSetQuery ctors with varargs terms as @Deprecated.
Ah I initially thought of doing this, but didn't know which was the right
way, I'll add now.
--
This is an automate
slow-J commented on code in PR #12864:
URL: https://github.com/apache/lucene/pull/12864#discussion_r1416299738
##
lucene/core/src/java/org/apache/lucene/document/KeywordField.java:
##
@@ -170,7 +171,9 @@ public static Query newExactQuery(String field, String
value) {
* @par
slow-J commented on code in PR #12864:
URL: https://github.com/apache/lucene/pull/12864#discussion_r1416300070
##
lucene/CHANGES.txt:
##
@@ -7,7 +7,8 @@ http://s.apache.org/luceneversions
API Changes
-
-(No changes)
+* GITHUB#12243: Mark TermInSetQuery ct
slow-J commented on PR #12864:
URL: https://github.com/apache/lucene/pull/12864#issuecomment-1841663134
Thanks for the review @gsmiller !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
slow-J commented on code in PR #12837:
URL: https://github.com/apache/lucene/pull/12837#discussion_r1416313463
##
lucene/CHANGES.txt:
##
@@ -67,6 +67,8 @@ API Changes
* GITHUB#11023: Adding -level param to CheckIndex, making the old -fast param
the default behaviour. (Jakub
slow-J commented on PR #12837:
URL: https://github.com/apache/lucene/pull/12837#issuecomment-1841683335
> Looks good! One minor question about CHANGES. Thanks!
Fixed!
Thanks for the review and for all the help with backporting!
--
This is an automated message from the Apache
jpountz commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1841712905
@uschindler FYI this is what I'm getting:
https://gist.github.com/jpountz/be81b1eb93c6118aac65c3679911f1d8. There are two
files: baseline.txt for the default impl, and contender.txt for
gsmiller merged PR #12864:
URL: https://github.com/apache/lucene/pull/12864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
gsmiller merged PR #12837:
URL: https://github.com/apache/lucene/pull/12837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
gsmiller closed issue #12243: Add a new static method for
KeywordField#newSetQuery to support collections parameter
URL: https://github.com/apache/lucene/issues/12243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1416379828
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1416403950
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
stefanvodita commented on PR #12844:
URL: https://github.com/apache/lucene/pull/12844#issuecomment-1841841701
@zhaih - I also tried your
[idea](https://github.com/apache/lucene/pull/12844#discussion_r1412533096)
about `beamWidth`. I passed `beamWidth` in to `NeighborArray` and then changed
dungba88 opened a new pull request, #12879:
URL: https://github.com/apache/lucene/pull/12879
### Description
This is the same with #12624, except for a slight change in implementation
of `ReadWriteDataOutput`. This PR keeps the original implementation that
BytesStore did, to make sur
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1416403950
##
lucene/core/src/java/org/apache/lucene/util/fst/ReadWriteDataOutput.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dungba88 commented on PR #12879:
URL: https://github.com/apache/lucene/pull/12879#issuecomment-1841967956
I think we'll likely go with the approach in #12624 (simpler despite some
potential regression). But this approach is to have some comparison, and in
case someone has strong argument fo
62 matches
Mail list logo
