jpountz commented on code in PR #12841: URL: https://github.com/apache/lucene/pull/12841#discussion_r1415234949
########## lucene/core/src/java/org/apache/lucene/store/DataOutput.java: ########## @@ -324,4 +326,42 @@ public void writeSetOfStrings(Set<String> set) throws IOException { writeString(value); } } + + /** + * Encode integers using group-varint. It uses {@link DataOutput#writeVInt VInt} to encode tail + * values that are not enough for a group. we need a long[] because this is what postings are + * using, all longs are actually required to be integers. + * + * @param values the values to write + * @param limit the number of values to write. + */ + public void writeGroupVInts(long[] values, int limit) throws IOException { Review Comment: I'm tempted to mark it `@lucene.experimental` to allow us to change the signature to use ints in the future. And likewise for its counterpart on `DataInput`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org