gsmiller commented on code in PR #12837: URL: https://github.com/apache/lucene/pull/12837#discussion_r1416221972
########## lucene/CHANGES.txt: ########## @@ -67,6 +67,8 @@ API Changes * GITHUB#11023: Adding -level param to CheckIndex, making the old -fast param the default behaviour. (Jakub Slowinski) +* GITHUB#12243: Remove TermInSetQuery ctors taking varargs param. KeywordField#newSetQuery now takes a collection. (Jakub Slowinski) Review Comment: I wonder if we should "forward-port" the CHANGES entry from your associated back-port PR as well? Otherwise the CHANGES message under 9.10 noting the deprecation will get lost with 10.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org