uschindler opened a new pull request, #12878: URL: https://github.com/apache/lucene/pull/12878
This PR fixes the issue found while coding the benchmark of Expressions module in #12873: The expressions module looks up the variables using the `DoubleValues#doubleValue` method, which throws `IOException`. Because the JVM does not do any exceptions checks, only the type system of javac compiler, some code calling `Expression#evaluate` could suddenly be confronted with a checked `IOException`, although this is not declared. It is not even possible to catch the Exception because compiler complains that it is not declared. Actually this should also be fixed in 9.x but this changes the method signature of the `Expression#evaluate` method and the impact is not too high. So it is for Lucene 10 only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
