dungba88 commented on code in PR #12844:
URL: https://github.com/apache/lucene/pull/12844#discussion_r1415164737
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java:
##########
@@ -351,7 +351,8 @@ public int[] getBulkOrdinals(FacetLabel... categoryPaths)
throws IOException {
}
} else {
indexesMissingFromCache =
- ArrayUtil.grow(indexesMissingFromCache, numberOfMissingFromCache +
1);
+ ArrayUtil.growInRange(
Review Comment:
I think we could add a comment here saying that indexesMissingFromCache
cannot grow beyond categoryPaths.
Was also thinking if an assert is needed here but the check in growInRange
should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
