uschindler commented on PR #12878: URL: https://github.com/apache/lucene/pull/12878#issuecomment-1841418704
> LGTM. I think an explicit IOException is better than wrapping in UncheckedIOException. The UncheckedIOException was just a workaround when I implemented the benchmark code. Wrapping inside ASM bytecode generation would be a desaster, so fix the bug correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
