mikemccand commented on PR #12829: URL: https://github.com/apache/lucene/pull/12829#issuecomment-1840782006
Thanks @s1monw -- I'll try to review soon. > The only think I am torn on is, if we set the num of children as a value for the DV field then I guess we should have a good usecase for that? One thing this would be helpful for is stronger consistency check in `CheckIndex`? Without doing this we can just validate that the parent docs are sorted correctly, whereas today we verify that all docs are sorted correctly (since user must provide a sort congruent with their doc-blocks). So we are weakening `CheckIndex` a bit by skipping checking the sort of the child docs ... if we stored the number of children in the new DV field, we could gain that back? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
