[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274490843 ## lucene/core/src/java/org/apache/lucene/util/hnsw/KnnResults.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-jira-archive] uschindler closed pull request #151: Bump certifi from 2022.6.15 to 2023.7.22 in /migration

uschindler closed pull request #151: Bump certifi from 2022.6.15 to 2023.7.22 in /migration URL: https://github.com/apache/lucene-jira-archive/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-jira-archive] uschindler closed pull request #150: Bump requests from 2.28.0 to 2.31.0 in /migration

uschindler closed pull request #150: Bump requests from 2.28.0 to 2.31.0 in /migration URL: https://github.com/apache/lucene-jira-archive/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] dependabot[bot] commented on pull request #151: Bump certifi from 2022.6.15 to 2023.7.22 in /migration

dependabot[bot] commented on PR #151: URL: https://github.com/apache/lucene-jira-archive/pull/151#issuecomment-1651200940 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

[GitHub] [lucene-jira-archive] dependabot[bot] commented on pull request #150: Bump requests from 2.28.0 to 2.31.0 in /migration

dependabot[bot] commented on PR #150: URL: https://github.com/apache/lucene-jira-archive/pull/150#issuecomment-1651201006 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274552571 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] jpountz commented on pull request #12405: Skip docs with Docvalues in NumericLeafComparator

jpountz commented on PR #12405: URL: https://github.com/apache/lucene/pull/12405#issuecomment-1651405438 @LuXugang I pushed a commit with the changes I had in mind, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] original-brownbear commented on a diff in pull request #12455: Clean up writing String to ByteBuffersDataOutput

original-brownbear commented on code in PR #12455: URL: https://github.com/apache/lucene/pull/12455#discussion_r1274811181 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java: ## @@ -549,66 +540,22 @@ private static int computeBlockSizeBitsFor(long bytes)

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274813058 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274813661 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274813992 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274813661 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274821505 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274825776 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274829365 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274825776 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274831373 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274837238 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274841199 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274861961 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] jpountz merged pull request #12455: Clean up writing String to ByteBuffersDataOutput

jpountz merged PR #12455: URL: https://github.com/apache/lucene/pull/12455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] benwtrent commented on pull request #12434: Add ParentJoin KNN support

benwtrent commented on PR #12434: URL: https://github.com/apache/lucene/pull/12434#issuecomment-1651725953 @msokolov && @alessandrobenedetti pinging y'all as you will probably be the most interested in this change. @alessandrobenedetti the original design did take some inspiration fro

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274892128 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ## @@ -278,7 +276,7 @@ public TopDocs search(String field

[GitHub] [lucene] jpountz commented on a diff in pull request #12405: Skip docs with Docvalues in NumericLeafComparator

jpountz commented on code in PR #12405: URL: https://github.com/apache/lucene/pull/12405#discussion_r1274926106 ## lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java: ## @@ -149,6 +149,11 @@ public void testLongSortOptimization() throws IOException { di

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274930576 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ## @@ -278,7 +276,7 @@ public TopDocs search(String fie

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274931211 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -79,14 +80,13 @@ protected KnnVectorsReader() {} * * @param field the vector fi

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274933739 ## lucene/core/src/java/org/apache/lucene/index/LeafReader.java: ## @@ -268,8 +272,68 @@ public abstract TopDocs searchNearestVectors( * @return the k nearest ne

[GitHub] [lucene] jpountz commented on issue #12463: Learned sorting algorithm for Lucene

jpountz commented on issue #12463: URL: https://github.com/apache/lucene/issues/12463#issuecomment-1651774505 This is certainly interesting and possibly applicable to Lucene as indexing involves a lot of sorting, but also looks complicated to integrate. Contributions are welcome. :) -- T

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274934075 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274938033 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274948941 ## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274952636 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ## @@ -278,7 +276,7 @@ public TopDocs search(String field

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275036311 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -79,14 +80,13 @@ protected KnnVectorsReader() {} * * @param field the vector fi

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275050439 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ## @@ -278,7 +276,7 @@ public TopDocs search(String fie

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275147272 ## lucene/core/src/java/org/apache/lucene/search/KnnFloatVectorQuery.java: ## @@ -78,8 +79,16 @@ public KnnFloatVectorQuery(String field, float[] target, int k, Query

[GitHub] [lucene] jpountz commented on a diff in pull request #12434: Add ParentJoin KNN support

jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275153663 ## lucene/core/src/java/org/apache/lucene/util/hnsw/TopKnnCollector.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [lucene] jpountz commented on a diff in pull request #12436: Move max vector dims limit to Codec

jpountz commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1275169909 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] jpountz closed pull request #12435: Remove sort for uniqueValues in NumericDocValues

jpountz closed pull request #12435: Remove sort for uniqueValues in NumericDocValues URL: https://github.com/apache/lucene/pull/12435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [lucene] jpountz commented on pull request #12435: Remove sort for uniqueValues in NumericDocValues

jpountz commented on PR #12435: URL: https://github.com/apache/lucene/pull/12435#issuecomment-1652157003 Closing as per the above comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275240534 ## lucene/core/src/java/org/apache/lucene/util/hnsw/TopKnnCollector.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275257249 ## lucene/core/src/java/org/apache/lucene/search/KnnCollector.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275258761 ## lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java: ## @@ -77,8 +78,16 @@ public KnnByteVectorQuery(String field, byte[] target, int k, Query

[GitHub] [lucene] benwtrent commented on a diff in pull request #12434: Add ParentJoin KNN support

benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275357936 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -79,14 +80,13 @@ protected KnnVectorsReader() {} * * @param field the vector fi

[GitHub] [lucene] jmazanec15 commented on issue #12342: Prevent VectorSimilarity.DOT_PRODUCT from returning negative scores

jmazanec15 commented on issue #12342: URL: https://github.com/apache/lucene/issues/12342#issuecomment-1652318052 Thanks @searchivarius sounds good. Additonally, @benwtrent in regards to https://github.com/apache/lucene/issues/12342#issuecomment-1650293826, I ran the non-transformed r

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #12436: Move max vector dims limit to Codec

mayya-sharipova commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1275409313 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #12436: Move max vector dims limit to Codec

mayya-sharipova commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1275409313 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] donnerpeter opened a new pull request, #12464: hunspell: make the hash table load factor customizable

donnerpeter opened a new pull request, #12464: URL: https://github.com/apache/lucene/pull/12464 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #12436: Move max vector dims limit to Codec

mayya-sharipova commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1275409313 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] gautamworah96 opened a new pull request, #12465: Potential bug in IndexedDISI90#SPARSE->advanceExactWithinBlock

gautamworah96 opened a new pull request, #12465: URL: https://github.com/apache/lucene/pull/12465 While upgrading our Lucene to 9.7 from 9.6 we noticed that a few tests were failing. On digging deeper into the tests we realized that they were failing on a particular assert. This one:

[GitHub] [lucene] LuXugang commented on a diff in pull request #12405: Skip docs with Docvalues in NumericLeafComparator

LuXugang commented on code in PR #12405: URL: https://github.com/apache/lucene/pull/12405#discussion_r1275760334 ## lucene/core/src/java/org/apache/lucene/util/NumericUtils.java: ## @@ -132,6 +132,52 @@ public static void add(int bytesPerDim, int dim, byte[] a, byte[] b, byte[]

[GitHub] [lucene] LuXugang commented on a diff in pull request #12405: Skip docs with Docvalues in NumericLeafComparator

LuXugang commented on code in PR #12405: URL: https://github.com/apache/lucene/pull/12405#discussion_r1275760334 ## lucene/core/src/java/org/apache/lucene/util/NumericUtils.java: ## @@ -132,6 +132,52 @@ public static void add(int bytesPerDim, int dim, byte[] a, byte[] b, byte[]