jpountz commented on code in PR #12405: URL: https://github.com/apache/lucene/pull/12405#discussion_r1274926106
########## lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java: ########## @@ -149,6 +149,11 @@ public void testLongSortOptimization() throws IOException { dir.close(); } + /** + * test that if we skip docs only with {@link org.apache.lucene.index.NumericDocValues}, result + * must be equal to no optimization case + */ Review Comment: did you mean to add a test there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org