benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1275050439
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ########## @@ -278,7 +276,7 @@ public TopDocs search(String field, float[] target, int k, Bits acceptDocs, int } @Override - public TopDocs search(String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) + public TopDocs search(String field, byte[] target, KnnResults knnResults, Bits acceptDocs) Review Comment: > if we should collect entries from the result NeighborQueue into the KnnResults object. 🤔 I could. This would then allow the change of the method definition to be `void` and we always just add things to the collector. ########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ########## @@ -278,7 +276,7 @@ public TopDocs search(String field, float[] target, int k, Bits acceptDocs, int } @Override - public TopDocs search(String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) + public TopDocs search(String field, byte[] target, KnnResults knnResults, Bits acceptDocs) Review Comment: > if we should collect entries from the result NeighborQueue into the KnnResults object. 🤔 I could. This would then allow the change of the method definition to be `void` and we always just add things to the collector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
