jpountz commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274952636
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ########## @@ -278,7 +276,7 @@ public TopDocs search(String field, float[] target, int k, Bits acceptDocs, int } @Override - public TopDocs search(String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) + public TopDocs search(String field, byte[] target, KnnResults knnResults, Bits acceptDocs) Review Comment: You are right, `ToParentJoinKnnResults` was not the best example. I'm mostly trying to think of whether bypassing the `KnnResults` object could yield issues and if we should collect entries from the result `NeighborQueue` into the `KnnResults` object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
