benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274930576
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java: ########## @@ -278,7 +276,7 @@ public TopDocs search(String field, float[] target, int k, Bits acceptDocs, int } @Override - public TopDocs search(String field, byte[] target, int k, Bits acceptDocs, int visitedLimit) + public TopDocs search(String field, byte[] target, KnnResults knnResults, Bits acceptDocs) Review Comment: > I'm assuming it's fixable, but maybe this old codec makes it challenging? This old codec doesn't use the typical search path. Honestly, since new versions don't allow writing new documents to old codecs, I didn't see support for a new way to search as critical. They would only need this change if a user indexed `join` documents into Lucene90 and haven't been able to deduplicate over parent doc id for the last year+. If that is the case, it seems weird that we haven't seen any issues related to this :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
