benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1274831373
########## lucene/core/src/java/org/apache/lucene/search/KnnResults.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +/** + * KnnResults is a collector for gathering kNN results and providing topDocs from the gathered + * neighbors + */ +public abstract class KnnResults { + + protected int visitedCount; + private final int visitLimit; + private final int k; + + protected KnnResults(int k, int visitLimit) { + this.visitLimit = visitLimit; + this.k = k; + } + + /** + * @return is the current result set marked as incomplete? + */ + public final boolean incomplete() { + return visitedCount >= visitLimit; + } + + public final void incVisitedCount(int count) { + assert count > 0; + this.visitedCount += count; + } + + /** + * @return the current visited count + */ + public final int visitedCount() { + return visitedCount; + } + + public final int visitLimit() { + return visitLimit; + } + + public final int k() { Review Comment: @jpountz ``` new NeighborQueue(knnResults.k(), true), ``` This is in the ``` public static KnnResults search( byte[] query, KnnResults knnResults, RandomAccessVectorValues<byte[]> vectors, VectorEncoding vectorEncoding, VectorSimilarityFunction similarityFunction, HnswGraph graph, Bits acceptOrds) ``` Method for both `float[]` and `byte[]`. Creating a `maxHeap` for keeping track of expected candidates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
