benwtrent commented on code in PR #12434:
URL: https://github.com/apache/lucene/pull/12434#discussion_r1275258761
##########
lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java:
##########
@@ -77,8 +78,16 @@ public KnnByteVectorQuery(String field, byte[] target, int
k, Query filter) {
@Override
protected TopDocs approximateSearch(LeafReaderContext context, Bits
acceptDocs, int visitedLimit)
throws IOException {
+ FieldInfo fi = context.reader().getFieldInfos().fieldInfo(field);
+ if (fi == null || fi.getVectorDimension() == 0) {
+ // The field does not exist or does not index vectors
+ return NO_RESULTS;
+ }
+ int k = Math.min(this.k,
context.reader().getByteVectorValues(fi.name).size());
Review Comment:
> that takes an int k, and call it here instead of the expert method that
takes a KnnCollector?
🤔 I suppose? This way this queries use the `final` method from the
leafReader and don't have to worry about this.
##########
lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java:
##########
@@ -77,8 +78,16 @@ public KnnByteVectorQuery(String field, byte[] target, int
k, Query filter) {
@Override
protected TopDocs approximateSearch(LeafReaderContext context, Bits
acceptDocs, int visitedLimit)
throws IOException {
+ FieldInfo fi = context.reader().getFieldInfos().fieldInfo(field);
+ if (fi == null || fi.getVectorDimension() == 0) {
+ // The field does not exist or does not index vectors
+ return NO_RESULTS;
+ }
+ int k = Math.min(this.k,
context.reader().getByteVectorValues(fi.name).size());
Review Comment:
> that takes an int k, and call it here instead of the expert method that
takes a KnnCollector?
🤔 I suppose? This way this queries use the `final` method from the
leafReader and don't have to worry about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
