[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445346816 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445346816 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445349212 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -305,10 +303,10 @@ public boolean equa

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-25 Thread GitBox
bruno-roustant commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r445353985 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-25 Thread GitBox
bruno-roustant commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r445352459 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] shalinmangar commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-06-25 Thread GitBox
shalinmangar commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r445295319 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/util/OnComplete.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] atris commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445356885 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,23 @@ public void handleRequestBody(SolrQueryRe

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445357108 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -587,11 +585,11 @@ public boolean equa

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445358817 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445358817 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
murblanc commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445361406 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java ## @@ -288,10 +287,11 @@ public boolean equals(Object o

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-649322479 @madrob Updated the timer usage -- let me know if this looks fine now. This is an automated message from the A

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-25 Thread GitBox
juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r445377800 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingIndexInput.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-25 Thread GitBox
juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r445379973 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingIndexInput.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144735#comment-17144735 ] Atri Sharma commented on SOLR-7344: --- Revisiting this issue. I would like a way to defin

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1608: LUCENE-9379: Encrypting Directory - functional but to optimize

2020-06-25 Thread GitBox
juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r445385656 ## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Created] (LUCENE-9417) Tessellator might fail when several holes share are connected to the same vertex

2020-06-25 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9417: Summary: Tessellator might fail when several holes share are connected to the same vertex Key: LUCENE-9417 URL: https://issues.apache.org/jira/browse/LUCENE-9417 Proj

[GitHub] [lucene-solr] markharwood commented on pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
markharwood commented on pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#issuecomment-649413439 Thanks for the reviews @jpountz and @jimczi I think I've addressed all the review comments now if you have a chance to take another look ---

[jira] [Commented] (SOLR-14066) Deprecate DIH

2020-06-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144786#comment-17144786 ] Jan Høydahl commented on SOLR-14066: How will you communicate migration path to the D

[GitHub] [lucene-solr] iverase opened a new pull request #1614: LUCENE-9417: Tessellator might fail when several holes share are connected to the same vertex

2020-06-25 Thread GitBox
iverase opened a new pull request #1614: URL: https://github.com/apache/lucene-solr/pull/1614 see https://issues.apache.org/jira/browse/LUCENE-9417 @nknize Can you have a look? This is an automated message from the Apa

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1610: LUCENE-9384: Backport for field sort optimization

2020-06-25 Thread GitBox
jimczi commented on a change in pull request #1610: URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r445460474 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -394,6 +399,21 @@ public String toString() { return buffer.toStri

[jira] [Commented] (SOLR-14066) Deprecate DIH

2020-06-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144829#comment-17144829 ] Ishan Chattopadhyaya commented on SOLR-14066: - > How will you communicate mig

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
jimczi commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445476294 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all optional

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
markharwood commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445490501 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all opt

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
jimczi commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445491309 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all optional

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
markharwood commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445497621 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all opt

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
jimczi commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445504910 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all optional

[jira] [Commented] (SOLR-14066) Deprecate DIH

2020-06-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144872#comment-17144872 ] Jan Høydahl commented on SOLR-14066: I'm a bit sceptical of leaving traces of DIH in

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
jimczi commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445505526 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all optional

[jira] [Commented] (SOLR-14022) Remove CDCR from Solr

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144884#comment-17144884 ] Cassandra Targett commented on SOLR-14022: -- bq. I think we should deprecate this

[jira] [Updated] (SOLR-14022) Deprecate CDCR from Solr in 8.x

2020-06-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14022: Summary: Deprecate CDCR from Solr in 8.x (was: Remove CDCR from Solr) Right, Cassa

[jira] [Updated] (SOLR-14022) Deprecate CDCR from Solr in 8.x

2020-06-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14022: Description: This ticket will deprecate CDCR in Solr 8x. (was: This ticket will re

[jira] [Commented] (SOLR-14066) Deprecate DIH

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144888#comment-17144888 ] Cassandra Targett commented on SOLR-14066: -- Just a rather late comment that this

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1541: RegExp - add case insensitive matching option

2020-06-25 Thread GitBox
markharwood commented on a change in pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r445538877 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -439,12 +441,19 @@ /** * Syntax flag, enables all opt

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144904#comment-17144904 ] Michael McCandless commented on LUCENE-8962: Thanks [~simonw].  I will have

[jira] [Created] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-14594: Summary: Bold title text in UI dashboard Key: SOLR-14594 URL: https://issues.apache.org/jira/browse/SOLR-14594 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-14594: - Attachment: SOLR-14594.patch > Bold title text in UI dashboard >

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445576784 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ## @@ -587,11 +585,11 @@ public boolean

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445578718 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java ## @@ -211,7 +211,7 @@ public boolean equals(Object obj) { @Override

[jira] [Commented] (SOLR-14586) replace the second function parameter in Map#computeIfAbsent with static vars

2020-06-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144949#comment-17144949 ] Jason Gerlowski commented on SOLR-14586: bq. Now, do you expect a developer to ru

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144951#comment-17144951 ] ASF subversion and git services commented on SOLR-13749: Commit 5

[jira] [Updated] (LUCENE-9328) Sorting by DocValues while grouping is slower than old good FieldCache

2020-06-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Summary: Sorting by DocValues while grouping is slower than old good FieldCache (was: S

[jira] [Commented] (SOLR-14022) Deprecate CDCR from Solr in 8.x

2020-06-25 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144963#comment-17144963 ] Timothy Potter commented on SOLR-14022: --- Check out Apache Pulsar's geo-replication

[GitHub] [lucene-solr] ErickErickson commented on pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson commented on pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#issuecomment-649582539 I'll merge this in a bit via another methodl This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] ErickErickson closed pull request #1579: SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread GitBox
ErickErickson closed pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144969#comment-17144969 ] Michael Sokolov commented on LUCENE-8962: - Yes, thanks Simon! I'll take a look t

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144999#comment-17144999 ] Munendra S N commented on SOLR-14329: - [~ctargett] {{cost}} parameter is not specific

[jira] [Closed] (SOLR-5387) Multi-Term analyser not working

2020-06-25 Thread Claire Chan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claire Chan closed SOLR-5387. - the resolution is verified. > Multi-Term analyser not working > --- > >

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-649613385 @madrob I aim to close this PR out today if possible -- so happy to stay awake late tonight if you want me to iterate :) -

[GitHub] [lucene-solr] madrob commented on a change in pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
madrob commented on a change in pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445647072 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -289,6 +295,23 @@ public void handleRequestBody(SolrQueryR

[GitHub] [lucene-solr] atris commented on pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris commented on pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-649628396 @madrob @anshumg Thank you for the review! This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (SOLR-10778) Address precommit WARNINGS

2020-06-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145028#comment-17145028 ] David Smiley commented on SOLR-10778: - I just want to mention that I think it was a b

[GitHub] [lucene-solr] atris merged pull request #1606: SOLR-14588: Implement Circuit Breakers

2020-06-25 Thread GitBox
atris merged pull request #1606: URL: https://github.com/apache/lucene-solr/pull/1606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145029#comment-17145029 ] ASF subversion and git services commented on SOLR-14588: Commit 7

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145030#comment-17145030 ] ASF subversion and git services commented on SOLR-14588: Commit 7

[GitHub] [lucene-solr] madrob commented on a change in pull request #1598: SOLR-14409: Existing violations allow bypassing policy rules when add…

2020-06-25 Thread GitBox
madrob commented on a change in pull request #1598: URL: https://github.com/apache/lucene-solr/pull/1598#discussion_r445653717 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/TestPolicy2.java ## @@ -516,6 +517,16 @@ public void testInfiniteLoop

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145039#comment-17145039 ] Mike Drob commented on SOLR-14588: -- [~atris] - needs a CHANGES entry too > Circuit Brea

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145051#comment-17145051 ] Andrzej Bialecki commented on SOLR-14588: - I must have missed the discussion abou

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1574: SOLR-14566: Add request-ID to all distrib-search requests

2020-06-25 Thread GitBox
gerlowskija commented on a change in pull request #1574: URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r445668363 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -70,6 +73,11 @@ private static final Logger log

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145057#comment-17145057 ] Atri Sharma commented on SOLR-14588: [~mdrob] Yes, realised that post pushing. Pushin

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145060#comment-17145060 ] ASF subversion and git services commented on SOLR-14588: Commit a

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145066#comment-17145066 ] Andrzej Bialecki commented on SOLR-14588: - [~atris] please see the comment above

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-06-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145089#comment-17145089 ] Michael Gibney commented on SOLR-13132: --- Sorry for the delayed response; these chan

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145095#comment-17145095 ] ASF subversion and git services commented on SOLR-13749: Commit 8

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1574: SOLR-14566: Add request-ID to all distrib-search requests

2020-06-25 Thread GitBox
dsmiley commented on a change in pull request #1574: URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r445702874 ## File path: solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java ## @@ -70,6 +73,11 @@ private static final Logger log = L

[jira] [Resolved] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13749. - Resolution: Fixed Finally :-) > Implement support for joining across collections with multiple s

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145101#comment-17145101 ] Marcus Eagan commented on SOLR-13749: - 🙌🏾 > Implement support for joining across

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145099#comment-17145099 ] Atri Sharma commented on SOLR-14588: [~ab] Thanks for commenting. I will add document

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-06-25 Thread Kevin Watters (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145104#comment-17145104 ] Kevin Watters commented on SOLR-13749: -- Awesome!  Thanks for taking care of the merg

[jira] [Commented] (SOLR-10778) Address precommit WARNINGS

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145117#comment-17145117 ] Erick Erickson commented on SOLR-10778: --- Well, the original intent was that multipl

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145132#comment-17145132 ] Joel Bernstein commented on SOLR-13688: --- This an interesting question. The streams

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145509#comment-17145509 ] Cassandra Targett commented on SOLR-14329: -- Ah, OK, my ignorance of {{fq}}'s is

[jira] [Comment Edited] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145509#comment-17145509 ] Cassandra Targett edited comment on SOLR-14329 at 6/25/20, 5:26 PM: ---

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145689#comment-17145689 ] Joel Bernstein commented on SOLR-13688: --- Maybe I'll add a simple command line tool

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:34 PM: --

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:34 PM: --

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:36 PM: --

[jira] [Comment Edited] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145689#comment-17145689 ] Joel Bernstein edited comment on SOLR-13688 at 6/25/20, 5:36 PM: --

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1610: LUCENE-9384: Backport for field sort optimization

2020-06-25 Thread GitBox
mayya-sharipova commented on a change in pull request #1610: URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r445737021 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -394,6 +399,21 @@ public String toString() { return buff

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-06-25 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145716#comment-17145716 ] Michael McCandless commented on LUCENE-8962: Beasting the branch (all Lucene

[jira] [Reopened] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-14574: --- git bisect has identified 102fc9d7e01966220927b90b13c72f3240890173 as the cause of repro

[jira] [Updated] (SOLR-14481) Add drill Streaming Expression

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14481: -- Attachment: SOLR-14481.patch > Add drill Streaming Expression > --

[jira] [Updated] (SOLR-14481) Add drill Streaming Expression

2020-06-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14481: -- Description: This ticket will add the *drill* Streaming Expression. The drill Streaming Expres

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-25 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145732#comment-17145732 ] Haoyu Zhai commented on LUCENE-8574: Made a PR([https://github.com/apache/lucene-sol

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145733#comment-17145733 ] Erick Erickson commented on SOLR-14574: --- [~hossman] I tried to stay away from any _

[jira] [Comment Edited] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145733#comment-17145733 ] Erick Erickson edited comment on SOLR-14574 at 6/25/20, 6:40 PM: --

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145746#comment-17145746 ] ASF subversion and git services commented on SOLR-14237: Commit a

[jira] [Commented] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145744#comment-17145744 ] ASF subversion and git services commented on SOLR-14307: Commit 1

[jira] [Commented] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145745#comment-17145745 ] ASF subversion and git services commented on SOLR-14594: Commit d

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145747#comment-17145747 ] Erick Erickson commented on SOLR-14588: --- [~atris] I believe this is producing the f

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145750#comment-17145750 ] ASF subversion and git services commented on SOLR-14237: Commit 8

[jira] [Commented] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145749#comment-17145749 ] ASF subversion and git services commented on SOLR-14594: Commit 0

[jira] [Commented] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145748#comment-17145748 ] ASF subversion and git services commented on SOLR-14307: Commit 3

[jira] [Resolved] (SOLR-14594) Bold title text in UI dashboard

2020-06-25 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-14594. -- Fix Version/s: 8.6 Resolution: Fixed > Bold title text in UI dashboard > ---

[GitHub] [lucene-solr] atris opened a new pull request #1615: SOLR-14588: Follow Up Fixes and Documentation

2020-06-25 Thread GitBox
atris opened a new pull request #1615: URL: https://github.com/apache/lucene-solr/pull/1615 This commit is a follow up to the original commit and adds more documentation and adds timing information for circuit breaker check only if circuit breakers are enabled ---

[GitHub] [lucene-solr] atris commented on pull request #1615: SOLR-14588: Follow Up Fixes and Documentation

2020-06-25 Thread GitBox
atris commented on pull request #1615: URL: https://github.com/apache/lucene-solr/pull/1615#issuecomment-649796637 @ErickErickson This fixes the test failure. I ran the test around 20 times with and without the failing seed -- seems clean. @sigram Updated the documentation -- let me

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145822#comment-17145822 ] ASF subversion and git services commented on SOLR-14541: Commit 1

[jira] [Commented] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145821#comment-17145821 ] ASF subversion and git services commented on SOLR-14541: Commit 9

[jira] [Resolved] (SOLR-14541) Ensure classes that implement equals implement hashCode or suppress warnings

2020-06-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14541. --- Fix Version/s: 8.6 Resolution: Fixed > Ensure classes that implement equals implement

[jira] [Commented] (SOLR-14574) Fix or suppress warnings in solr/core/src/test

2020-06-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145836#comment-17145836 ] ASF subversion and git services commented on SOLR-14574: Commit 5

  1   2   >