[
https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145117#comment-17145117
]
Erick Erickson commented on SOLR-10778:
---------------------------------------
Well, the original intent was that multiple people were going to work on
various subdirectories. I disagree about CHANGES.txt in this case, these
changes touch so many files that I'd rather have a trail of what was going on.
Anyway, it's far too late to change the approach now, I should have this all
wrapped up today.
> Address precommit WARNINGS
> --------------------------
>
> Key: SOLR-10778
> URL: https://issues.apache.org/jira/browse/SOLR-10778
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.6
> Reporter: Andrew Musselman
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: dated-warnings, dated-warnings.log, notclosed.txt
>
>
> During precommit we are seeing lots of warnings. Im turning this into an
> umbrella issue about getting precommit warnings out of the code in general.
> Yes, this will take a while.
> See SOLR-10809 for getting all warnings out of solr/core. I want to
> selectively have precommit fail when "some part" of the code is clean so we
> don't backslide, and solr/core was the finest granularity I could see how to
> change.
> If you read more of the comments here, you can see that there are some
> serious code refactoring that could be done. I'm electing to simply
> SuppressWarnings rather than re-arrange code at this point whenever the code
> is tricky. If anyone goes back in and tries to clean the code up, then can
> remove the annotation(s).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
