[GitHub] [lucene-solr] noblepaul commented on issue #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream

2019-12-25 Thread GitBox
noblepaul commented on issue #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream URL: https://github.com/apache/lucene-solr/pull/1116#issuecomment-568863673 You can create another method with the appropriate return type, correct? -

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361278515 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +6

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

2019-12-25 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003169#comment-17003169 ] Ishan Chattopadhyaya commented on SOLR-13101: - Sorry, haven't looked into the

[GitHub] [lucene-solr] a-siuniaev opened a new pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

2019-12-25 Thread GitBox
a-siuniaev opened a new pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122 # Description Added DSL support for queries - to have the ability to refer from domain.filter. It supports both sing

[jira] [Commented] (SOLR-13778) Windows JDK SSL Test Failure trend: SSLException: Software caused connection abort: recv failed

2019-12-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003206#comment-17003206 ] Dawid Weiss commented on SOLR-13778: Thanks Uwe! > Windows JDK SSL Test Failure tren

[GitHub] [lucene-solr] uschindler merged pull request #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit

2019-12-25 Thread GitBox
uschindler merged pull request #1114: LUCENE-9109: Use stack walker to implement TestSecurityManager's detection of test JVM exit URL: https://github.com/apache/lucene-solr/pull/1114 This is an automated message from the Apa

[jira] [Commented] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003236#comment-17003236 ] ASF subversion and git services commented on LUCENE-9109: - Commi

[jira] [Commented] (SOLR-13984) Solr should run inside a SecurityManager

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003258#comment-17003258 ] ASF subversion and git services commented on SOLR-13984: Commit e

[jira] [Commented] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003263#comment-17003263 ] ASF subversion and git services commented on LUCENE-9109: - Commi

[jira] [Commented] (SOLR-14120) Solr Admin UI breaks when using IE 11

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003261#comment-17003261 ] ASF subversion and git services commented on SOLR-14120: Commit 3

[jira] [Commented] (SOLR-14146) Zookeeper version not resolved in RefGuide

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003262#comment-17003262 ] ASF subversion and git services commented on SOLR-14146: Commit a

[jira] [Commented] (SOLR-14143) Add request-logging to securing solr page

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003259#comment-17003259 ] ASF subversion and git services commented on SOLR-14143: Commit b

[jira] [Commented] (SOLR-14144) add IP-based access control to securing solr page

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003260#comment-17003260 ] ASF subversion and git services commented on SOLR-14144: Commit b

[jira] [Created] (LUCENE-9111) Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM 14-ea+27-1339)

2019-12-25 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9111: --- Summary: Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM 14-ea+27-1339) Key: LUCENE-9111 URL: https://issues.apache.org/jira/browse/LUCENE-9111 Pr

[jira] [Updated] (LUCENE-9111) Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM 14-ea+27-1339)

2019-12-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9111: Description: Plenty of these recently {code} JRE version: OpenJDK Runtime Environment (14.0+27) (b

[jira] [Commented] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003267#comment-17003267 ] ASF subversion and git services commented on LUCENE-9109: - Commi

[jira] [Comment Edited] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003268#comment-17003268 ] Uwe Schindler edited comment on LUCENE-9109 at 12/25/19 12:53 PM:

[jira] [Resolved] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9109. --- Resolution: Fixed > Use Java 9+ StackWalker to implement TestSecurityManager's detection of

[jira] [Commented] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003268#comment-17003268 ] Uwe Schindler commented on LUCENE-9109: --- I backported the removal of SecurityManag

[jira] [Comment Edited] (LUCENE-9109) Use Java 9+ StackWalker to implement TestSecurityManager's detection of JVM exit

2019-12-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003268#comment-17003268 ] Uwe Schindler edited comment on LUCENE-9109 at 12/25/19 2:09 PM: -

[jira] [Commented] (LUCENE-9111) Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM 14-ea+27-1339)

2019-12-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003284#comment-17003284 ] Uwe Schindler commented on LUCENE-9111: --- Known issue, already in progress: https:

[jira] [Resolved] (LUCENE-9111) Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM 14-ea+27-1339)

2019-12-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9111. - Resolution: Duplicate > Frequent JVM failures on IdealLoopTree::est_loop_flow_merge_sz() (VM >

[jira] [Commented] (SOLR-14149) Remove non-changes from CHANGES.txt

2019-12-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003291#comment-17003291 ] Erick Erickson commented on SOLR-14149: --- bq. The layout of the distribution is docu

[jira] [Commented] (SOLR-14149) Remove non-changes from CHANGES.txt

2019-12-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003293#comment-17003293 ] David Smiley commented on SOLR-14149: - Hey; improve away on that as you wish :-) I c

[GitHub] [lucene-solr] Traktormaster opened a new pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
Traktormaster opened a new pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123 # Description This is an improved version of the patch submitted to the Jira issue about a week ag

[jira] [Commented] (SOLR-12490) Query DSL supports for further referring and exclusion in JSON facets

2019-12-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003319#comment-17003319 ] Mikhail Khludnev commented on SOLR-12490: - [https://github.com/apache/lucene-solr

[GitHub] [lucene-solr] uschindler commented on issue #1120: LUCENE-9110: Switch tests to use StackWalker

2019-12-25 Thread GitBox
uschindler commented on issue #1120: LUCENE-9110: Switch tests to use StackWalker URL: https://github.com/apache/lucene-solr/pull/1120#issuecomment-568923838 I removed the remaining 4 tests that required the full stack trace and rewrote them to use the new methods. I don't care of requesti

[GitHub] [lucene-solr] dweiss commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build

2019-12-25 Thread GitBox
dweiss commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build URL: https://github.com/apache/lucene-solr/pull/1121#issuecomment-568923921 This looks good to me, Jan. The only question is whether we want to include it now or later -- the dependencies is something

[GitHub] [lucene-solr] janhoy commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build

2019-12-25 Thread GitBox
janhoy commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build URL: https://github.com/apache/lucene-solr/pull/1121#issuecomment-568924313 Sure, we can include it closer to master merge. This is an

[jira] [Comment Edited] (SOLR-14137) Boosting by date (and perhaps others) shows a steady decline 6.6->8.3

2019-12-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003365#comment-17003365 ] Erick Erickson edited comment on SOLR-14137 at 12/25/19 7:21 PM: --

[jira] [Updated] (SOLR-14137) Boosting by date (and perhaps others) shows a steady decline 6.6->8.3

2019-12-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14137: -- Attachment: second_run.png Status: Open (was: Open) This is a more tightly controlled

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
janhoy commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361333891 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +62,7

[jira] [Updated] (SOLR-14102) FacetModule use number of responses from shards as number of shards

2019-12-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-14102: Status: Patch Available (was: Open) > FacetModule use number of responses from shards as n

[jira] [Reopened] (SOLR-13817) Deprecate and remove legacy SolrCache implementations

2019-12-25 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reopened SOLR-13817: - They should, I missed it - I'll fix it in a couple days. > Deprecate and remove legacy SolrC

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

2019-12-25 Thread GitBox
mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361335287 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ###

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

2019-12-25 Thread GitBox
mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361335644 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ###

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets

2019-12-25 Thread GitBox
mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing of json.queries for referring in JSON facets URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361335761 ## File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java ###

[jira] [Comment Edited] (SOLR-12490) Query DSL supports for further referring and exclusion in JSON facets

2019-12-25 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003319#comment-17003319 ] Mikhail Khludnev edited comment on SOLR-12490 at 12/25/19 8:18 PM:

[jira] [Commented] (SOLR-14131) Add maxQueryLength option to DirectSolrSpellchecker

2019-12-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003371#comment-17003371 ] ASF subversion and git services commented on SOLR-14131: Commit 8

[jira] [Updated] (SOLR-14131) Add maxQueryLength option to DirectSolrSpellchecker

2019-12-25 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-14131: -- Fix Version/s: 8.5 Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [lucene-solr] noblepaul opened a new pull request #1124: SOLR:14151: Schema components to be loadable from packages

2019-12-25 Thread GitBox
noblepaul opened a new pull request #1124: SOLR:14151: Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124 DO NOT commit WIP This is an automated message from the Apache Git Ser

[jira] [Updated] (SOLR-14151) Make schema components load from packages

2019-12-25 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14151: -- Description: Example: {code:xml} {code} * When a package i

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361366362 ## File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java ## @@ -420,7 +420,7

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361366578 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -519,7 +518,7 @@ priva

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361367240 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -954,4 +987,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361367530 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +62,

[GitHub] [lucene-solr] kkewwei opened a new pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler

2019-12-25 Thread GitBox
kkewwei opened a new pull request #1125: LUCENE-9096: Implementation of CompressingTermVectorsWriter.flushOffsets can be simpler URL: https://github.com/apache/lucene-solr/pull/1125 Description In CompressingTermVectorsWriter.flushOffsets, the calculation of sumPos and sumOffsets is a l

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
noblepaul commented on a change in pull request #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361375529 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java ## @@ -62,7 +6

[GitHub] [lucene-solr] noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo

2019-12-25 Thread GitBox
noblepaul commented on issue #1109: More pervasive use of PackageLoader / PluginInfo URL: https://github.com/apache/lucene-solr/pull/1109#issuecomment-568981311 @dsmiley The comments are not supposed to be personal. These are my observations on the code/PR. I'm sure somebody is going to re

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361375534 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361374902 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361374225 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361374322 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361376198 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left

2019-12-25 Thread GitBox
dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361370892 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uh