dsmiley commented on a change in pull request #1109: More pervasive use of 
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361367240
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
 ##########
 @@ -954,4 +987,46 @@ public static void persistConfLocally(SolrResourceLoader 
loader, String resource
     }
   }
 
+  // TODO document these methods...
 
 Review comment:
   The SRL is pervasively used across the codebase to load stuff (hence 
"resource loader" in its name).  If CoreContainer/SolrCore is now the right 
place, then this is a big change; no?
   
   BTW, Wouldn't the ConfigSet object be a more befitting place to store the 
version association than the SolrCore?  Isn't params.json (which is where the 
association is) stored in the config set?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to