mkhludnev commented on a change in pull request #1122: SOLR-12490 Added parsing
of json.queries for referring in JSON facets
URL: https://github.com/apache/lucene-solr/pull/1122#discussion_r361335287
##########
File path: solr/core/src/java/org/apache/solr/request/json/RequestUtil.java
##########
@@ -191,7 +191,9 @@ public static void processParams(SolrRequestHandler
handler, SolrQueryRequest re
}
// implement compat for existing components...
- JsonQueryConverter jsonQueryConverter = new JsonQueryConverter();
+ JsonQueryConverter jsonQueryConverter = (JsonQueryConverter)
req.getContext()
Review comment:
I think it's necessary only for the earlier "dynamic" approach. I suppose
it's not necessary in the eager one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
