dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361367530
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java
##########
@@ -62,7 +62,7 @@ public static IndexSchema buildIndexSchema(String
resourceName, SolrConfig confi
PluginInfo info = config.getPluginInfo(IndexSchemaFactory.class.getName());
IndexSchemaFactory factory;
if (null != info) {
- factory = config.getResourceLoader().newInstance(info.className,
IndexSchemaFactory.class);
+ factory = config.getResourceLoader().newInstance(info,
IndexSchemaFactory.class);
Review comment:
"That's plain wrong. " Please work on your tone @noblepaul . There is no
right/wrong here; we are exploring what the future holds together; it has not
been written yet with no spec to judge right/wrong. It would be more correct
to say "According to my vision, the SRL should not know about packages".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]