dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified
highlighter with word separator never gives context to the left
URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361374902
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/LengthGoalBreakIterator.java
##########
@@ -116,28 +128,20 @@ public int previous() {
return baseIter.previous();
}
- // called while the current position is the start of a new passage; find end
of passage
+ // NOTE: this.fragmentEndFromPreceding is used instead of the parameter!
+ // This is a big diversion from the API a BreakIterator should implement,
but specifically this optimization is fine.
@Override
public int following(int followingIdx) {
Review comment:
based on your comment, rename this parameter to _unused_followingIdx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
