janhoy commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361333891
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java
##########
@@ -62,7 +62,7 @@ public static IndexSchema buildIndexSchema(String
resourceName, SolrConfig confi
PluginInfo info = config.getPluginInfo(IndexSchemaFactory.class.getName());
IndexSchemaFactory factory;
if (null != info) {
- factory = config.getResourceLoader().newInstance(info.className,
IndexSchemaFactory.class);
+ factory = config.getResourceLoader().newInstance(info,
IndexSchemaFactory.class);
Review comment:
Sound like an exciting design, SRL in response of loading stuff. Could not
SRL ask SolrCore about version details if it is a core-level package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
