dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361366362
##########
File path: solr/core/src/java/org/apache/solr/core/DirectoryFactory.java
##########
@@ -420,7 +420,7 @@ static DirectoryFactory loadDirectoryFactory(SolrConfig
config, CoreContainer cc
final DirectoryFactory dirFactory;
if (info != null) {
log.debug(info.className);
- dirFactory = config.getResourceLoader().newInstance(info.className,
DirectoryFactory.class);
+ dirFactory = config.getResourceLoader().newInstance(info,
DirectoryFactory.class);
Review comment:
IndexSchema can be shared ("shareSchema" option) but SolrConfig at present
cannot be. Lets suppose it can be for the sake of argument -- wouldn't this be
a reason to _not_ use SolrCore related things? Otherwise another Collection
using the same SolrConfig might theoretically refer to something it shouldn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]