dsmiley commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876638709
Thanks Dawid for the deep dive and Uwe for helping with the Eclipse support!
For this minor build improvement, I wasn't going to update CHANGES.txt but
let me know if you think I sh
github-actions[bot] commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876119114
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086589925
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2876103288
I am complete pissed off, bye! Do whatever you want. Damn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086578233
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086578233
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086555819
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086555819
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086560622
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086541603
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r208652
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086528285
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086526348
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086524077
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
rmuir commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875984812
Please don't enable this slowness, there is zero benefit as javac already
checks it.
We don't need it. Just avoid it.
--
This is an automated message from the Apache Git Service.
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875975752
> Just to confirm that my observations are correct: Did you measure slowness
with this PR if executed in Java 25?
I don't see a lot of slowdown at all when I run on Java 21+. It is
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875971667
Ok, I think the second snippet of yours is spot-on - yes. Still, I'd prefer
using javac options. I understand them. Everyone who uses javac will. ecj's
"numeric" compliance options are a
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875957427
But at end I don't care if we set source+target or just compliance. It is
effectively doing the same at end. We should just make sure to not set
"release".
Just to confirm that
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875948758
> There is a lot of complexity involved in checking this release
compatibility. I'd leave it out to javac and just use source/target here. No
need to double-check the same stuff twice
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875517286
Yep, I'd stick to using what was there before. Not a bad idea to replace
java properties if you've already done it though.
--
This is an automated message from the Apache Git Service.
T
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875507747
Thanks, so I'd like to revert those changes here with a clear warning next
to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875453187
There is a lot of complexity involved in checking this release
compatibility. I'd leave it out to javac and just use source/target here. No
need to double-check the same stuff twice and s
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875430075
> the compiler and also introduced an - undocumented? - 'ct.sym' file, which
is part of the JDK and is a zip file with class signatures from previous Java
version. Couldn't find the d
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875439078
P.S.: It could be that the newest version of the ct.sym generator uses the
Classfile API in a similar way like I refactored it last week. Have not checked
source code, the last time I
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875450439
> The most important question here: Did you find out if "compliance" flag
uses release or not?
Looking at the code, it seems to be equivalent to setting the release flag.
h
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875439928
Also - the final cherry on top of this cake - why we can't see such
significant difference on main is very likely on this change:
https://bugs.openjdk.org/browse/JDK-8283336
If you
dweiss commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875398128
I dug deep into this, fascinating. So the problem is indeed in the release
check flag. Here is a flame graph from a slowed-down execution of ecj:
![image](https://github.com/user-attac
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874579010
Use Jdk 25 EA to check. Jenkins does this all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
rmuir commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874569307
Sorry, I don't have a better idea other than, try it on branch_10x, using a
JDK24 where the "target" is 21.
Or maybe "template" the file the same way as is done for `gradle eclipse`
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874423257
But of course it may be different with the command line parameters. But to
me it looks like Eclipse disables the release flag and compliance is just a
combination of above pictures "s
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874416695
> > To me all is fine, just try to figure out with @dweiss and @rmuir if the
release flag is enabled or not.
>
> Please don't do it here. Please make separate PR if you want to
rmuir commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874408782
> To me all is fine, just try to figure out with @dweiss and @rmuir if the
release flag is enabled or not.
Please don't do it here. Please make separate PR if you want to enable that
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085644555
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085643653
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -151,7 +149,6 @@
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.comp
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2874398269
I fixed the eclipse setup in
https://github.com/apache/lucene/pull/14651/commits/965a00b006a419288a4284be8ef1d2f365484fee
It basically adds the follwoing to the settingss file g
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085357012
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085353966
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pro
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085333753
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085324735
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085322774
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
dsmiley commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085319708
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
p
dsmiley commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873711276
> The command line of ECJ should not be modified.
Why; is it perfection? It seems the "compliance" wasn't being set.
--
This is an automated message from the Apache Git Service.
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085299262
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085298100
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085295730
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
dsmiley commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085289312
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclipse.j
dsmiley commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085285767
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
p
dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085278571
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
pr
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873032572
But in general: Iw would keep the properties file as is and inject the Java
version there. The command line of ECJ should not be modified.
--
This is an automated message from the A
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873029220
Something like:
```groovy
filter(ReplaceTokens, tokens: [
'ecj-lint-config':
ecjLintFile.getText('UTF-8').replaceAll(/=error\b/, '=' + errorMode)
uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2873022378
> I'm hoping an Eclipse user could improve this PR to address that side of
the equation. I've never used Eclipse.
Not sure how, but if we remove the java version from the ecj ja
dsmiley commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2872842933
I'm hoping an Eclipse user could improve this PR to address that side of the
equation. I've never used Eclipse.
--
This is an automated message from the Apache Git Service.
To respond
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084825680
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
dsmiley commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084819372
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
p
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084813285
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -15,9 +15,7 @@
org.eclipse.jdt.core.compiler.annotation.owning=org.eclipse.jdt.annotation.Ownin
org.eclips
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084815606
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -151,7 +149,6 @@
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.comp
uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084810166
##
gradle/validation/ecj-lint.gradle:
##
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+assert project.java.sourceCompatibility ==
rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2084808570
##
gradle/validation/ecj-lint/ecj.javadocs.prefs:
##
@@ -151,7 +149,6 @@
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=error
org.eclipse.jdt.core.compiler.
62 matches
Mail list logo
