dsmiley commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085319708
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
Review Comment:
Based on the ECJ documentation I linked with that excerpt, it's not going to
set "release", so we're safe. I should bring back the comment reworded as a
warning to *not* set "release" and to refer back to #484 for further info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
