rmuir commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086541603
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
- args += [ "-source", project.java.sourceCompatibility ]
- args += [ "-target", project.java.targetCompatibility ]
+ args += ["-$project.java.sourceCompatibility"] // "compliance" level
Review Comment:
It isn't nonsense: the title of the PR is to "remove hard-coded versions"
not "Change ECJ CLI flags".
If gradle can't "template" a file and replace some simple variables without
ALSO changing CLI flags, perhaps we should look at a different build tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
