uschindler commented on PR #14651:
URL: https://github.com/apache/lucene/pull/14651#issuecomment-2875948758

   > There is a lot of complexity involved in checking this release 
compatibility. I'd leave it out to javac and just use source/target here. No 
need to double-check the same stuff twice and slow down the build.
   
   This is not true, I checked the code. When you specify `-release` on command 
line (and only then), it sets relaese version:
   
   
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/85f1797ab9f379eeffd203d94522fbf3c6a4e7ce/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/batch/Main.java#L2588
   
   If you just set compliance level it does not do this,
   
   Later in the code it compares the current compliance level and release 
version via `(this.releaseVersion != null && this.complianceLevel < jdkLevel)` 
-- At this place it sets up the "Horrible slowness":
   
   
https://github.com/eclipse-jdt/eclipse.jdt.core/blob/85f1797ab9f379eeffd203d94522fbf3c6a4e7ce/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/batch/Main.java#L5191-L5198
   
   So basically, the code in this PR is fine as it does not set the release 
version unless you use "release". If you just give compliance level it is 
identical to setting source/target.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to