uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086533332
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
- args += [ "-source", project.java.sourceCompatibility ]
- args += [ "-target", project.java.targetCompatibility ]
+ args += ["-$project.java.sourceCompatibility"] // "compliance" level
Review Comment:
Actually the two lines above do the same. The change can be applied or not,
the result is identical. At end it sets compliance level.
I agree with Dawid, we can keep source/target as it is easier to understand
for javac people, but the whole discussion here is really nonsense. We never
wanted to make it slow and we have heard you now multiple times complaining. I
just repeat: "YES I HEARD YOU!" I have said multiple times, the code above
won't make it slow. We also tested it with Java 25 and a backported version".
So please stop arguing. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
