Re: [PR] Build: remove hard-coded Java versions from ecj.javadocs.prefs [lucene]

[via GitHub]

dweiss commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2085295730


##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
 
         args += [ "-d", "none" ]
 
+        assert project.java.sourceCompatibility == 
project.java.targetCompatibility
+
         // Compilation environment.
-        // we use -source/-target as it is significantly faster than --release

Review Comment:
   Hmm... I'm looking at the link you included in the patch? And I see this:
   
![image](https://github.com/user-attachments/assets/8f7f33c7-5352-463d-86cf-157d8c13dc21)
   
![image](https://github.com/user-attachments/assets/084f4899-3ca7-425e-a9d3-0e7e76c4e9bd)
   
   So it looks like -[num] is equivalent to setting --source, --target and 
--release to the same number? Am I reading it wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org