dweiss commented on code in PR #14651: URL: https://github.com/apache/lucene/pull/14651#discussion_r2085298100
########## gradle/validation/ecj-lint.gradle: ########## @@ -94,10 +96,10 @@ allprojects { args += [ "-d", "none" ] + assert project.java.sourceCompatibility == project.java.targetCompatibility + // Compilation environment. - // we use -source/-target as it is significantly faster than --release Review Comment: you didn't see the switch because it was commented out - because it was much much slower than source/target and we use javac with java version compliance settings anyway (so anything wrong there would be detected before it hits ecj). I think this duplicated checking + slow execution of compliance mode in ecj was the motivation to comment it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org