Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-19 Thread via GitHub
uschindler commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2240961607 > Thanks for your detailed response! > > > The will be no overhead anymore on unrelated threads that don't use MemorySegments; at the moment it deoptimizes all threads.

Re: [PR] Inline skip data into postings lists [lucene]

2024-07-19 Thread via GitHub
jpountz commented on code in PR #13585: URL: https://github.com/apache/lucene/pull/13585#discussion_r1685274565 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsWriter.java: ## @@ -0,0 +1,563 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Inline skip data into postings lists [lucene]

2024-07-19 Thread via GitHub
jpountz commented on PR #13585: URL: https://github.com/apache/lucene/pull/13585#issuecomment-2240948449 > I couldn't see where we also wrote the file pointer into pos/pay files Indeed level 0 doesn't write pointers into pos/pay, it only records the total term freq of the block to kno

Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-19 Thread via GitHub
dsmiley commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2240911730 Thanks for your detailed response! > The will be no overhead anymore on unrelated threads that don't use MemorySegments; at the moment it deoptimizes all threads. Much

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
goankur commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-2240878772 > I definitely want to play around more with @goankur 's PR here and see what performance looks like across machines, but will be out of town for a bit. > > There is a script to ru

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
rmuir commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1685214866 ## lucene/core/build.gradle: ## @@ -14,12 +14,59 @@ * See the License for the specific language governing permissions and * limitations under the License. */ +plug

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
goankur commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-2240860811 > > > With the updated compile flags, the performance of auto-vectorized code is slightly better than explicitly vectorized code (see results). Interesting thing to note is that both C-b

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
rmuir commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1685207476 ## lucene/core/build.gradle: ## @@ -14,12 +14,59 @@ * See the License for the specific language governing permissions and * limitations under the License. */ +plug

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1685196099 ## lucene/core/build.gradle: ## @@ -14,12 +14,59 @@ * See the License for the specific language governing permissions and * limitations under the License. */ +pl

Re: [PR] Only check liveDocs is null one time in FreqProxTermsWriter.applyDeletes [lucene]

2024-07-19 Thread via GitHub
github-actions[bot] commented on PR #13506: URL: https://github.com/apache/lucene/pull/13506#issuecomment-2240791109 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add XNOR in FixedBitSet. [lucene]

2024-07-19 Thread via GitHub
github-actions[bot] commented on PR #13540: URL: https://github.com/apache/lucene/pull/13540#issuecomment-2240791037 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] HnswLock: access locks via hash and only use for concurrent indexing [lucene]

2024-07-19 Thread via GitHub
Edarke commented on PR #13581: URL: https://github.com/apache/lucene/pull/13581#issuecomment-2239723532 @msokolov Sorry to interject, but the hash function `Objects.hash(level, node) % NUM_LOCKS;` seems like it is prone to lock contention if workers have power of 2 offsets. Would it be wort

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
uschindler commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684589983 ## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java: ## @@ -157,6 +157,8 @@ static Arena getSharedArena( arenas.comput

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
uschindler commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684583078 ## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ## @@ -47,9 +48,12 @@ boolean acquire() { int value; while (true) { v

Re: [PR] HnswLock: access locks via hash and only use for concurrent indexing [lucene]

2024-07-19 Thread via GitHub
msokolov commented on PR #13581: URL: https://github.com/apache/lucene/pull/13581#issuecomment-2239511706 I've been running a bunch of tests -- ram buffer was set to 64MB (I think this is what's checked in on luceneutil main rn). I believe to get the most accurate assessment we should sum t

Re: [PR] HnswLock: access locks via hash and only use for concurrent indexing [lucene]

2024-07-19 Thread via GitHub
benwtrent commented on PR #13581: URL: https://github.com/apache/lucene/pull/13581#issuecomment-2239473886 OK, I ran this over 500k vectors, merging with 8 threads, flushing every 10MB. Main ``` Force merge done in: 123535 ms 0.966 1.94 50 100 16 250

Re: [PR] Inline skip data into postings lists [lucene]

2024-07-19 Thread via GitHub
mikemccand commented on code in PR #13585: URL: https://github.com/apache/lucene/pull/13585#discussion_r1684540391 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsWriter.java: ## @@ -0,0 +1,563 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Inline skip data into postings lists [lucene]

2024-07-19 Thread via GitHub
mikemccand commented on code in PR #13585: URL: https://github.com/apache/lucene/pull/13585#discussion_r1684500686 ## lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsWriter.java: ## @@ -0,0 +1,563 @@ +/* + * Licensed to the Apache Software Foundation (AS

[I] ConcurrentMergeScheduler may spawn more merge threads than specified [lucene]

2024-07-19 Thread via GitHub
aoli-al opened a new issue, #13593: URL: https://github.com/apache/lucene/issues/13593 ### Description I saw a failure in the test `testMaxMergeCount` due to concurrency issues. ``` 𞤃𞤮𞤪𞤧𞤮 19, 2024 12:08:03 𞤇𞤎 com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaught

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-07-19 Thread via GitHub
Mikep86 commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1684517801 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +101,16 @@ public Weight createWeight( .rewrite(new Con

Re: [PR] SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider [lucene-solr]

2024-07-19 Thread via GitHub
itygh commented on PR #2086: URL: https://github.com/apache/lucene-solr/pull/2086#issuecomment-2239408033 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider [lucene-solr]

2024-07-19 Thread via GitHub
dsmiley closed pull request #2086: SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider URL: https://github.com/apache/lucene-solr/pull/2086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] SOLR-14985: Slow indexing and search performance when using HttpClusterStateProvider [lucene-solr]

2024-07-19 Thread via GitHub
dsmiley commented on PR #2086: URL: https://github.com/apache/lucene-solr/pull/2086#issuecomment-2239406669 Superseded by [#2571](https://github.com/apache/solr/pull/2571) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684456806 ## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ## @@ -47,9 +48,12 @@ boolean acquire() { int value; while (true) {

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
magibney commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684426889 ## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java: ## @@ -157,6 +157,8 @@ static Arena getSharedArena( arenas.computeI

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
magibney commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684426889 ## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java: ## @@ -157,6 +157,8 @@ static Arena getSharedArena( arenas.computeI

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2239235073 > > different drill sideways dimension might want to use different Collector types > > I'm trying to wrap my head around this -- can you offer an example where someone might want

Re: [PR] Inline skip data into postings lists [lucene]

2024-07-19 Thread via GitHub
mikemccand commented on PR #13585: URL: https://github.com/apache/lucene/pull/13585#issuecomment-2239177486 SO EXCITING, thank you for tackling this @jpountz -- I'll have a closer look soon. #4036 is the long-ago issue where we started some discussion and linked to a cool paper about

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684380274 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/LongAggregationsFacetRecorder.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684372027 ## lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java: ## @@ -0,0 +1,714 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
msokolov commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2239124290 > different drill sideways dimension might want to use different Collector types I'm trying to wrap my head around this -- can you offer an example where someone might want to

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684359348 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684356330 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/GetOrd.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684352125 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684343630 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684338424 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldLeafCollector.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684332997 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/taxonomy/TaxonomyChildrenOrdinalIterator.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684331911 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684322639 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684319585 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/FacetRecorder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-07-19 Thread via GitHub
jpountz commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1684308932 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +99,7 @@ public Weight createWeight( .rewrite(new Const

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684302960 ## lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java: ## @@ -0,0 +1,714 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-07-19 Thread via GitHub
Mikep86 commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1684299328 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +99,7 @@ public Weight createWeight( .rewrite(new Const

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
msokolov commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-2239023786 > An alternative option to putting this in core, is to put it in say misc, allowing users creating KnnVectorsFormat to hook into it through the Lucene99FlatVectorsFormat and FlatVectors

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684298127 ## lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java: ## @@ -0,0 +1,714 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684286479 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/MultiFacetsRecorder.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684286479 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/MultiFacetsRecorder.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684268054 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/MultiFacetsRecorder.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [I] Investigate possible perf regression with off-heap scoring on JDK 22 [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on issue #13575: URL: https://github.com/apache/lucene/issues/13575#issuecomment-2238973013 On _main_ running on ARM, I don't see any difference between JDK 21 and JDK 22. Here's the output of the VectorScorerBenchmark. ``` $ /Users/chegar/binaries/jdk-21.0.2

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684253137 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/RangeOrdLabelBiMap.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684244139 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/RangeOrdLabelBiMap.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684229413 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/LongAggregationsFacetRecorder.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684213414 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684203696 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/RangeFacetCutter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684197604 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/Reducer.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684195737 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/Reducer.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684167228 ## lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java: ## @@ -0,0 +1,714 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on PR #13572: URL: https://github.com/apache/lucene/pull/13572#issuecomment-2238753829 Just to expand a little on a previous comment I made above. > Could Lucene ever have this directly in one of its modules? An alternative option to putting this in `core

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r168408 ## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ## @@ -47,9 +48,12 @@ boolean acquire() { int value; while (true) {

Re: [PR] Add levels to DocValues skipper index [lucene]

2024-07-19 Thread via GitHub
iverase merged PR #13563: URL: https://github.com/apache/lucene/pull/13563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r168408 ## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ## @@ -47,9 +48,12 @@ boolean acquire() { int value; while (true) {

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-07-19 Thread via GitHub
ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1684097085 ## lucene/core/src/java/org/apache/lucene/index/IndexFileNames.java: ## @@ -142,6 +143,26 @@ public static String stripSegmentName(String filename) { return

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684034644 ## lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java: ## @@ -0,0 +1,714 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1683970221 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1683933633 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1683926444 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/OrdLabelBiMap.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684007169 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/taxonomy/TaxonomyOrdLabelBiMap.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Avoid wrap readers without soft-deletes (#13588) [lucene]

2024-07-19 Thread via GitHub
dnhatn merged PR #13591: URL: https://github.com/apache/lucene/pull/13591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Simplify advancing on postings/impacts enums [lucene]

2024-07-19 Thread via GitHub
jpountz closed pull request #12838: Simplify advancing on postings/impacts enums URL: https://github.com/apache/lucene/pull/12838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove useless todo in PerThreadPKLookup. [lucene]

2024-07-19 Thread via GitHub
jpountz merged PR #13589: URL: https://github.com/apache/lucene/pull/13589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-19 Thread via GitHub
uschindler commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2238591954 Hi David, sorry for late response. In fact there problem is quite simple. Every IndexInput#close() costs time in the thread calling this. This time is linear to the number of

Re: [PR] Remove useless todo in PerThreadPKLookup. [lucene]

2024-07-19 Thread via GitHub
jpountz commented on PR #13589: URL: https://github.com/apache/lucene/pull/13589#issuecomment-2238614984 Thank for closing the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-19 Thread via GitHub
uschindler commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2238603586 P.S.: The code optimizations were committed for JDK 23 already. Backport is under discussion. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Compute facets while collecting [lucene]

2024-07-19 Thread via GitHub
epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1683968342 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on