stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684322639
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.recorders; + +import static org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator.NO_MORE_ORDS; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.internal.hppc.IntCursor; +import org.apache.lucene.internal.hppc.IntIntHashMap; +import org.apache.lucene.sandbox.facet.abstracts.FacetLeafRecorder; +import org.apache.lucene.sandbox.facet.abstracts.FacetRecorder; +import org.apache.lucene.sandbox.facet.abstracts.FacetRollup; +import org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator; + +/** + * {@link FacetRecorder} to count facets. TODO: add an option to keep counts in an array, to improve + * performance for facets with small number of ordinals e.g. range facets. Options: - {@link + * org.apache.lucene.sandbox.facet.abstracts.FacetLeafCutter} can inform {@link FacetLeafRecorder} + * about expected number of facet ordinals ({@link + * org.apache.lucene.sandbox.facet.FacetFieldCollector} can orchestrate that). If expeted facet ord + * number is below some threshold - use array instead of a map? - first 100/1k counts in array, the + * rest - in a map; the limit can also be provided in a constructor? It is similar to what + * LongValuesFacetCounts does today. + */ +public class CountFacetRecorder implements FacetRecorder { + + // TODO: deprecate - it is cheaper to merge during reduce than to lock threads during collection. + // TODO: alternatively, we can consider collecting 2 (3, 4, ..., can be parametrizes) slices to a + // single sync map + // which can reduce thread contention compared to single sync map for all slices; at the + // same time there will + // be less work for reduce method. So far reduce wasn't a bottleneck for us, but it is + // definitely not free. + private final boolean useSyncMap; + + /** Create */ + public CountFacetRecorder() { + this(false); + } + + IntIntHashMap values; + List<IntIntHashMap> perLeafValues; + + /** + * Create. + * + * @param useSyncMap if true, use single sync map for all leafs. + */ + public CountFacetRecorder(boolean useSyncMap) { + super(); + if (useSyncMap) { + values = new SafeIntIntHashMap(); + } else { + // Has to be synchronizedList as we have one recorder per all slices. + perLeafValues = Collections.synchronizedList(new ArrayList<>()); + } + this.useSyncMap = useSyncMap; + } + + /** Get count for provided ordinal. */ + public int getCount(int ord) { + // TODO: allow or don't allow missing values? Review Comment: You're right. I was thinking of other aggregations while talking about count. For count, I think 0 makes sense. Can we resolve the TODO then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
