epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1684268054
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/MultiFacetsRecorder.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.recorders; + +import java.io.IOException; +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.sandbox.facet.abstracts.FacetLeafRecorder; +import org.apache.lucene.sandbox.facet.abstracts.FacetRecorder; +import org.apache.lucene.sandbox.facet.abstracts.FacetRollup; +import org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator; + +/** {@link FacetRecorder} that contains multiple FacetRecorders. */ +public final class MultiFacetsRecorder implements FacetRecorder { + + private final FacetRecorder[] delegates; + + /** Constructor */ + public MultiFacetsRecorder(FacetRecorder... delegates) { + this.delegates = delegates; + } + + @Override + public FacetLeafRecorder getLeafRecorder(LeafReaderContext context) throws IOException { + // TODO: find out why streams gives StackOverFlowError? + // FacetLeafRecorder[] leafDelegates = Arrays.stream(delegates).map(k -> + // getLeafRecorder(context)).toArray(FacetLeafRecorder[]::new); + FacetLeafRecorder[] leafDelegates = new FacetLeafRecorder[delegates.length]; + for (int i = 0; i < delegates.length; i++) { + leafDelegates[i] = delegates[i].getLeafRecorder(context); + } + return new MultiFacetsLeafRecorder(leafDelegates); + } + + @Override + public OrdinalIterator recordedOrds() { + assert delegates.length > 0; + return delegates[0].recordedOrds(); + } + + @Override + public boolean isEmpty() { + assert delegates.length > 0; + return delegates[0].isEmpty(); + } + + @Override + public void reduce(FacetRollup facetRollup) throws IOException { + for (FacetRecorder recorder : delegates) { + recorder.reduce(facetRollup); + } + } + + private static final class MultiFacetsLeafRecorder implements FacetLeafRecorder { + + private final FacetLeafRecorder[] delegates; + + private MultiFacetsLeafRecorder(FacetLeafRecorder[] delegates) { + this.delegates = delegates; + } + + @Override + public void record(int docId, int facetId) throws IOException { + // TODO: handle collection terminated exception Review Comment: Removing the comment for now - there are no Recorder that that throw `CollectionTerminatedException` today, so handling list of exhausted sub-Recorders feels like an overkill. The main use case I'm thinking about is a boolean recorder, that collects until some condition is met (e.g. specific ordinal is collected?) It can throw `CollectionTerminatedException` to let calling LeafCollecror that it doesn't need any more hits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
