epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1684034644


##########
lucene/demo/src/java/org/apache/lucene/demo/facet/SandboxFacetsExample.java:
##########
@@ -0,0 +1,714 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.demo.facet;
+
+import static org.apache.lucene.facet.FacetsConfig.DEFAULT_INDEX_FIELD_NAME;
+import static 
org.apache.lucene.sandbox.facet.ComparableUtils.rankCountOrdToComparable;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import org.apache.lucene.analysis.core.WhitespaceAnalyzer;
+import org.apache.lucene.document.Document;
+import org.apache.lucene.document.DoubleDocValuesField;
+import org.apache.lucene.document.NumericDocValuesField;
+import org.apache.lucene.facet.DrillDownQuery;
+import org.apache.lucene.facet.DrillSideways;
+import org.apache.lucene.facet.FacetField;
+import org.apache.lucene.facet.FacetResult;
+import org.apache.lucene.facet.FacetsConfig;
+import org.apache.lucene.facet.LabelAndValue;
+import org.apache.lucene.facet.MultiLongValuesSource;
+import org.apache.lucene.facet.range.LongRange;
+import org.apache.lucene.facet.taxonomy.FacetLabel;
+import org.apache.lucene.facet.taxonomy.TaxonomyReader;
+import org.apache.lucene.facet.taxonomy.directory.DirectoryTaxonomyReader;
+import org.apache.lucene.facet.taxonomy.directory.DirectoryTaxonomyWriter;
+import org.apache.lucene.index.DirectoryReader;
+import org.apache.lucene.index.IndexWriter;
+import org.apache.lucene.index.IndexWriterConfig;
+import org.apache.lucene.index.IndexWriterConfig.OpenMode;
+import org.apache.lucene.sandbox.facet.ComparableUtils;
+import org.apache.lucene.sandbox.facet.FacetFieldCollector;
+import org.apache.lucene.sandbox.facet.FacetFieldCollectorManager;
+import org.apache.lucene.sandbox.facet.abstracts.OrdLabelBiMap;
+import org.apache.lucene.sandbox.facet.abstracts.OrdToComparable;
+import org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator;
+import org.apache.lucene.sandbox.facet.abstracts.Reducer;
+import org.apache.lucene.sandbox.facet.ordinal_iterators.TopnOrdinalIterator;
+import org.apache.lucene.sandbox.facet.ranges.LongRangeFacetCutter;
+import org.apache.lucene.sandbox.facet.ranges.RangeOrdLabelBiMap;
+import org.apache.lucene.sandbox.facet.recorders.CountFacetRecorder;
+import org.apache.lucene.sandbox.facet.recorders.LongAggregationsFacetRecorder;
+import org.apache.lucene.sandbox.facet.recorders.MultiFacetsRecorder;
+import 
org.apache.lucene.sandbox.facet.taxonomy.TaxonomyChildrenOrdinalIterator;
+import org.apache.lucene.sandbox.facet.taxonomy.TaxonomyFacetsCutter;
+import org.apache.lucene.sandbox.facet.taxonomy.TaxonomyOrdLabelBiMap;
+import org.apache.lucene.search.CollectorOwner;
+import org.apache.lucene.search.DoubleValuesSource;
+import org.apache.lucene.search.IndexSearcher;
+import org.apache.lucene.search.LongValuesSource;
+import org.apache.lucene.search.MatchAllDocsQuery;
+import org.apache.lucene.search.MultiCollectorManager;
+import org.apache.lucene.search.TopDocs;
+import org.apache.lucene.search.TopScoreDocCollectorManager;
+import org.apache.lucene.store.ByteBuffersDirectory;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.IOUtils;
+
+/** Demo for sandbox faceting. */
+public class SandboxFacetsExample {
+
+  private final Directory indexDir = new ByteBuffersDirectory();
+  private final Directory taxoDir = new ByteBuffersDirectory();
+  private final FacetsConfig config = new FacetsConfig();
+
+  /** Empty constructor */
+  public SandboxFacetsExample() {
+    config.setHierarchical("Publish Date", true);
+  }
+
+  /** Build the example index. */
+  void index() throws IOException {
+    IndexWriter indexWriter =
+        new IndexWriter(
+            indexDir, new IndexWriterConfig(new 
WhitespaceAnalyzer()).setOpenMode(OpenMode.CREATE));
+
+    // Writes facet ords to a separate directory from the main index
+    DirectoryTaxonomyWriter taxoWriter = new DirectoryTaxonomyWriter(taxoDir);
+
+    Document doc = new Document();
+    doc.add(new FacetField("Author", "Bob"));
+    doc.add(new FacetField("Publish Date", "2010", "10", "15"));
+    doc.add(new NumericDocValuesField("Price", 10));
+    doc.add(new NumericDocValuesField("Units", 9));
+    doc.add(new DoubleDocValuesField("Popularity", 3.5d));
+    indexWriter.addDocument(config.build(taxoWriter, doc));
+
+    doc = new Document();
+    doc.add(new FacetField("Author", "Lisa"));
+    doc.add(new FacetField("Publish Date", "2010", "10", "20"));
+    doc.add(new NumericDocValuesField("Price", 4));
+    doc.add(new NumericDocValuesField("Units", 2));
+    doc.add(new DoubleDocValuesField("Popularity", 4.1D));
+    indexWriter.addDocument(config.build(taxoWriter, doc));
+
+    doc = new Document();
+    doc.add(new FacetField("Author", "Lisa"));
+    doc.add(new FacetField("Publish Date", "2012", "1", "1"));
+    doc.add(new NumericDocValuesField("Price", 3));
+    doc.add(new NumericDocValuesField("Units", 5));
+    doc.add(new DoubleDocValuesField("Popularity", 3.9D));
+    indexWriter.addDocument(config.build(taxoWriter, doc));
+
+    doc = new Document();
+    doc.add(new FacetField("Author", "Susan"));
+    doc.add(new FacetField("Publish Date", "2012", "1", "7"));
+    doc.add(new NumericDocValuesField("Price", 8));
+    doc.add(new NumericDocValuesField("Units", 7));
+    doc.add(new DoubleDocValuesField("Popularity", 4D));
+    indexWriter.addDocument(config.build(taxoWriter, doc));
+
+    doc = new Document();
+    doc.add(new FacetField("Author", "Frank"));
+    doc.add(new FacetField("Publish Date", "1999", "5", "5"));
+    doc.add(new NumericDocValuesField("Price", 9));
+    doc.add(new NumericDocValuesField("Units", 6));
+    doc.add(new DoubleDocValuesField("Popularity", 4.9D));
+    indexWriter.addDocument(config.build(taxoWriter, doc));
+
+    IOUtils.close(indexWriter, taxoWriter);
+  }
+
+  /** User runs a query and counts facets only without collecting the matching 
documents. */
+  List<FacetResult> facetsOnly() throws IOException {
+    //// (1) init readers
+    DirectoryReader indexReader = DirectoryReader.open(indexDir);
+    IndexSearcher searcher = new IndexSearcher(indexReader);
+    TaxonomyReader taxoReader = new DirectoryTaxonomyReader(taxoDir);
+
+    //// (2) init collector
+    TaxonomyFacetsCutter defaultTaxoCutter =
+        new TaxonomyFacetsCutter(DEFAULT_INDEX_FIELD_NAME, config, taxoReader);
+    CountFacetRecorder defaultRecorder = new CountFacetRecorder(false);
+
+    FacetFieldCollectorManager<CountFacetRecorder> collectorManager =
+        new FacetFieldCollectorManager<>(defaultTaxoCutter, defaultTaxoCutter, 
defaultRecorder);
+
+    //// (2.1) if we need to collect data using multiple different collectors, 
e.g. taxonomy and
+    // ranges,
+    ////       or even two taxonomy facets that use different Category List 
Field, we can use
+    // MultiCollectorManager, e.g.:
+    // TODO: add a demo for it.
+    // TaxonomyFacetsCutter publishDateCutter = new
+    // TaxonomyFacetsCutter(config.getDimConfig("Publish Date"), taxoReader);
+    // CountFacetRecorder publishDateRecorder = new CountFacetRecorder(false);
+    // FacetFieldCollectorManager<CountFacetRecorder> 
publishDateCollectorManager = new
+    // FacetFieldCollectorManager<>(publishDateCutter, publishDateRecorder);
+    // MultiCollectorManager drillDownCollectorManager = new
+    // MultiCollectorManager(authorCollectorManager, 
publishDateCollectorManager);
+    // Object[] results = searcher.search(new MatchAllDocsQuery(), 
drillDownCollectorManager);
+
+    //// (3) search
+    // Search returns the same Recorder we created - so we can ignore results
+    searcher.search(new MatchAllDocsQuery(), collectorManager);
+
+    //// (4) Get top 10 results by count for Author and Publish Date
+    // This object is used to get topN results by count
+    OrdToComparable<ComparableUtils.IntOrdComparable> countComparable =
+        ComparableUtils.countOrdToComparable(defaultRecorder);
+    // We don't actually need to use FacetResult, it is up to client what to 
do with the results.
+    // Here we just want to demo that we can still do FacetResult as well
+    List<FacetResult> results = new ArrayList<>(2);
+    // This object provides labels for ordinals.
+    OrdLabelBiMap ordLabels = new TaxonomyOrdLabelBiMap(taxoReader);
+    for (String dimension : List.of("Author", "Publish Date")) {
+      //// (4.1) Chain two ordinal iterators to get top N children
+      OrdinalIterator childrenIternator =
+          new TaxonomyChildrenOrdinalIterator(

Review Comment:
   Hmm, I think it depends on particular index/query, in particular which 
collection is larger - children for selected parent of ordinals that have 
counts for current query? I'd suggest to keep current implementation for now, 
which is based on `TaxonomyFacets#getTopChildrenForPath` and experiment with 
that as a follow up task? I think `TaxonomyFacets#getTopChildrenForPath` has 
similar todo comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to