ChrisHegarty commented on code in PR #13570:
URL: https://github.com/apache/lucene/pull/13570#discussion_r1684097085
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileNames.java:
##########
@@ -142,6 +143,26 @@ public static String stripSegmentName(String filename) {
return filename;
}
+ /**
Review Comment:
Cool! I added an arbitrary limit to the ref counting, after which the
`RefCountedShareArena` is removed from the map, and a new instance is created
to handle the next set of group files. 👍
I chose a limit of 256. This is quite arbitrary, but we can amend it once
we're happy with the mechanism. We can even make this a property of the
provider, and make it configurable through a system property.
I left the grouping as it was. That is:
1. for segment files, one group per generation, and one group for all other
files without a generation.
2. No grouping for files are not valid codec segment files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
