epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1683968342
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet; + +import org.apache.lucene.sandbox.facet.abstracts.GetOrd; +import org.apache.lucene.sandbox.facet.abstracts.OrdToComparable; +import org.apache.lucene.sandbox.facet.recorders.CountFacetRecorder; +import org.apache.lucene.sandbox.facet.recorders.LongAggregationsFacetRecorder; + +/** + * Collection of static methods to provide most common comparables for sandbox faceting. You can + * also use it as an example for creating your own {@link OrdToComparable} to enable custom facets + * sorting. + */ +public class ComparableUtils { + private ComparableUtils() {} + + private static class SkeletalGetOrd implements GetOrd { + int ord; + + @Override + public int getOrd() { + return ord; + } + } + + /** Result of */ + public static class OrdComparable extends SkeletalGetOrd implements Comparable<OrdComparable> { Review Comment: Yes, I think it's better! I've also renamed other classes that extend Comparable in this file, e.g.`IntOrdComparable` -> `ComparableIntOrd`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
