[
https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187479#comment-17187479
]
Bruno Roustant commented on SOLR-14782:
---
Looking into this.
> QueryElevationCompon
[
https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant reassigned SOLR-14782:
-
Assignee: Bruno Roustant
> QueryElevationComponent does not handle escaped query terms
>
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683586352
I see. In that case, the way forward should be to maybe use Solr.XML only
for now to unblock you, but revisit it later to leverage clusterprops
before the release. @nobl
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683584869
Ishan, Noble is suggesting not to use solr.xml and hard code the plugin to
use if I understand his point correctly.
What you suggest is how it’s in the PR: legacy wil
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683584098
I did answer above your comment and alternate proposal about fetching
property values. I believe our users will not be tormented if we provide them
an efficient implementat
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683582331
Legacy can be hard-coded. It will be used Unless overridden by solr.xml (to
use something else).
On Mon, 31 Aug, 2020, 11:41 am Ilan Ginzburg,
wrote:
> If
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683580121
If we hard code a default plugin, how do users get to chose if they’d rather
keep legacy or rules based assign instead? How do they pass parameters to the
plugin?
---
noblepaul edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which
placement plugin to use
What is wrong with hard coding?
>t's easy to have a s
rmuir commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683533223
>> That check was added to make merging easier. See the related issues about
it. I don't care.
That is really wrong to do. If master is on java 11, then master is on jav
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187352#comment-17187352
]
ASF subversion and git services commented on LUCENE-9490:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187351#comment-17187351
]
ASF subversion and git services commented on LUCENE-9456:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187353#comment-17187353
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
noblepaul edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which
placement plugin to use
What is wrong with hard coding?
>t's easy to have a s
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9490.
---
Resolution: Fixed
Should be OK now.
> gradlew checkMissingDocsDefault fails on JDK 15 or la
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187348#comment-17187348
]
ASF subversion and git services commented on LUCENE-9490:
-
Commi
noblepaul edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which
placement plugin to use
What is wrong with hard coding?
>t's easy to have a s
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which
placement plugin to use
What is wrong with hard coding?
-
[
https://issues.apache.org/jira/browse/SOLR-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187344#comment-17187344
]
Jakob Furrer commented on SOLR-6152:
Can someone please change/update the affected ver
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187345#comment-17187345
]
Uwe Schindler commented on LUCENE-9490:
---
I know, it's the other task:
{noformat}
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-9490:
---
For some strange reason, the task still fails on Policeman Jenkins:
https://jenkins.thetaphi.de/
[
https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187342#comment-17187342
]
Uwe Schindler commented on LUCENE-9475:
---
I created a pull request to change the ch
[
https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187342#comment-17187342
]
Uwe Schindler edited comment on LUCENE-9475 at 8/30/20, 11:45 PM:
uschindler opened a new pull request #1806:
URL: https://github.com/apache/lucene-solr/pull/1806
This PR changes the legacy setp of the checkSourcePatterns task to directly
execute the checker code in the running Gradle VM.
Because of Ant compatibility we preserved the old code using
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683483373
As this class is not part of any code in branch_8x, I think
validateSourcePatterns should exclude it for this check. Can be quickyl
implemented.
I am dealing with
uschindler edited a comment on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683481056
> seems the build fails because of var use? that check is broken: master is
java 11
That check was added to make merging easier. See the related issues about
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683481056
> seems the build fails because of var use? that check is broken: master is
java 11
That check was added to make merging easier. See the related issues about
it. I
rmuir commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683477788
seems the build fails because of `var` use? that check is broken: master is
java 11
This is an automated mess
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187336#comment-17187336
]
Mark Robert Miller commented on SOLR-14788:
---
Test are back to a pretty great st
uschindler commented on a change in pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#discussion_r479814878
##
File path: gradle/validation/forbidden-apis.gradle
##
@@ -103,6 +103,13 @@ allprojects { prj ->
]
}
+// Doclet does use exotic
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683464627
I did move it to a composite subproject. So it is now separate from Solr and
Lucene, yet still in the source tree. We can move it back to buildSrc or
anything else once it's
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683463331
A yet another alternative is to use a composite build to compile it locally.
Then it is a separate project (top-level project) on its own and is not part of
the Lucene/ Solr
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683462911
Making it a true project discovered two bugs the moment I tried to compile
it. So there are benefits. It also makes development faster, at least in the
early stage (because i
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683454888
> If that's the case, I'd copypaste Robert's code into the
render-javadocs.gradle file as another inner class (as the syntax of Java is
mostly the same with Gradle).
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187311#comment-17187311
]
Robert Muir commented on LUCENE-9215:
-
if we can check javadocs without relying on o
uschindler edited a comment on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683452425
Hi,
I still disagree. We have many classes in the build that are Groovy-based
(like the javadocs task). What's the difference to that one, just because it's
wri
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683452425
Hi,
I still disagree. We have many classes in the build that are Groovy, based
(like the javadocs task). Wht's the difference to that on, just because it's
written in
uschindler edited a comment on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683452425
Hi,
I still disagree. We have many classes in the build that are Groovy-based
(like the javadocs task). Wht's the difference to that on, just because it's
writt
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683447537
It's a bit of a chicken and egg problem (boostrapping gradle itself). I do
think a separate project for this is beneficial here - at least it's clear what
it is, has a (poten
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683446509
> a318310 Made missing doclet a regular project. This also means all the
checks are applied to it (forbidden APIs, etc.).
I was so happy that `lucene/tools` was gon
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187293#comment-17187293
]
Uwe Schindler edited comment on LUCENE-9215 at 8/30/20, 5:16 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187293#comment-17187293
]
Uwe Schindler commented on LUCENE-9215:
---
The good thing with this error is: It inf
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187292#comment-17187292
]
Uwe Schindler commented on LUCENE-9215:
---
Hi,
bq. The overriden method issue can b
[
https://issues.apache.org/jira/browse/SOLR-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187273#comment-17187273
]
Mikhail Khludnev commented on SOLR-14540:
-
https://github.com/apache/lucene-solr/
mkhludnev opened a new pull request #1805:
URL: https://github.com/apache/lucene-solr/pull/1805
Contributing example of block join drill-seideway facets to Ref Guide
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187272#comment-17187272
]
Dawid Weiss commented on LUCENE-9215:
-
The overriden method issue can be solved with
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9215:
Attachment: overrides.patch
> replace checkJavaDocs.py with doclet
> -
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187271#comment-17187271
]
Dawid Weiss commented on LUCENE-9215:
-
Done. The move has an upside in that all regu
[
https://issues.apache.org/jira/browse/SOLR-14794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187266#comment-17187266
]
ASF subversion and git services commented on SOLR-14794:
Commit a
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187270#comment-17187270
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187269#comment-17187269
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187267#comment-17187267
]
ASF subversion and git services commented on LUCENE-9435:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187268#comment-17187268
]
ASF subversion and git services commented on LUCENE-9474:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187262#comment-17187262
]
Dawid Weiss commented on LUCENE-9215:
-
bq. i already hit the solr issue, i just solv
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187261#comment-17187261
]
Robert Muir commented on LUCENE-9215:
-
OK [~dweiss] I'm all done now, all yours. Tha
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187260#comment-17187260
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187258#comment-17187258
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187256#comment-17187256
]
Robert Muir commented on LUCENE-9215:
-
I'm merging one more time (i already hit the
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187253#comment-17187253
]
Dawid Weiss commented on LUCENE-9215:
-
One more thing - the doclet currently sits in
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187252#comment-17187252
]
Dawid Weiss commented on LUCENE-9215:
-
I did overlook the setting in Solr's top-buil
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187249#comment-17187249
]
Dawid Weiss commented on LUCENE-9215:
-
Ah, darn. Sorry. It should be trivial to merg
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187247#comment-17187247
]
Robert Muir commented on LUCENE-9215:
-
No worries, I will merge my changes with your
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
It's easy to have a single `PropertyValue` in
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683434613
> So, I have two main problems with this PR
I consider this progress 😃
> 1. Using `solr.xml`
There's no other place to set default config (not ha
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187242#comment-17187242
]
Dawid Weiss commented on LUCENE-9215:
-
[~rcmuir] moved stuff around a bit, hope you'
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
It's easy to have a single `PropertyValue` in
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
It's easy to have a single `PropertyValue` in
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
It's easy to have a single `PropertyValue` in
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187240#comment-17187240
]
ASF subversion and git services commented on LUCENE-9456:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187239#comment-17187239
]
ASF subversion and git services commented on LUCENE-9456:
-
Commi
dsmiley merged pull request #1803:
URL: https://github.com/apache/lucene-solr/pull/1803
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683434613
> So, I have two main problems with this PR
I consider this progress 😃
> 1. Using `solr.xml`
There's no other place to set default config (not hard code
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683433584
> Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
It's easy to have a single `PropertyValue` interface
[
https://issues.apache.org/jira/browse/LUCENE-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187236#comment-17187236
]
ASF subversion and git services commented on LUCENE-9474:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187235#comment-17187235
]
Alexandre Rafalovitch commented on SOLR-13652:
--
I think this is a great disc
Alexandre Rafalovitch created SOLR-14798:
Summary: Config API: indexConfig output includes all defaults
Key: SOLR-14798
URL: https://issues.apache.org/jira/browse/SOLR-14798
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14783:
-
Description:
Now that Data Import Handler (SOLR-14066) has been depreciated in 8.
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187216#comment-17187216
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
noblepaul opened a new pull request #1804:
URL: https://github.com/apache/lucene-solr/pull/1804
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187214#comment-17187214
]
ASF subversion and git services commented on LUCENE-9215:
-
Commi
noblepaul edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420028
Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
`public interface PropertyFetcher {`
`Pr
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420148
So, I have two main problems with this PR
1. Using `solr.xml`
2. having 2 interfaces for each property
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420028
Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
`public interface PropertyFetcher {`
`PropertyF
rmuir commented on a change in pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#discussion_r479766765
##
File path: buildSrc/src/main/java/org/apache/lucene/gradle/MissingDoclet.java
##
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation
rmuir commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683413964
Thanks @dweiss @uschindler @mocobeta please, make any changes if you have
the time and motiviation. I agree with the suggestions: plumbing the correct
inputs sounds great to
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187195#comment-17187195
]
Tomoko Uchida commented on LUCENE-9490:
---
bq. Robert made such great progress with
[
https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9475:
Description:
Once the bulk of the Ant build system is removed, stuff will come bubbling up
out of
[
https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187194#comment-17187194
]
ASF subversion and git services commented on LUCENE-9435:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9435.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Clean up ant compatability remnants in Gr
dweiss merged pull request #1799:
URL: https://github.com/apache/lucene-solr/pull/1799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on a change in pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#discussion_r479761009
##
File path: buildSrc/src/main/java/org/apache/lucene/gradle/MissingDoclet.java
##
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/LUCENE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187192#comment-17187192
]
Dawid Weiss commented on LUCENE-9490:
-
bq. Yes I think the simplified regex is corre
uschindler edited a comment on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683408276
I agree with Dawid. At the beginning I did not like his approach to
centralize everything, but this makes maintenance easier, as you have a better
overview.
The
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683410761
Just to be clear, Robert - I can correct this, let me know if you're ok with
it.
This is an automated messag
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683408548
I would make the settings of the linter `@Input` options of the
RenderJavadocs task, prepoulated with the project variables (like Javadocs
URLs).
--
uschindler commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683408276
I agree with Dawid. At the beginning I did not like his approach to
centralize everything, but this makes maintenance easier, as you have a better
overview.
The build.
[
https://issues.apache.org/jira/browse/SOLR-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187183#comment-17187183
]
Erick Erickson commented on SOLR-13652:
---
Agreed. Either we need a copyField directi
[
https://issues.apache.org/jira/browse/SOLR-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187181#comment-17187181
]
Erick Erickson commented on SOLR-14784:
---
Oops, didn't see you saw this I filed
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187180#comment-17187180
]
Erick Erickson commented on LUCENE-9456:
[~dsmiley] see: SOLR-14784, [~jpountz]
dweiss commented on pull request #1802:
URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683402017
This looks really good already! My personal preference would be to keep the
processing options inside the render javadoc file, rather than pushing them
down to each project's
[
https://issues.apache.org/jira/browse/SOLR-14785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187166#comment-17187166
]
Gitterh commented on SOLR-14785:
Thank you. I've found the issue, it was that in applicat
1 - 100 of 105 matches
Mail list logo
