uschindler commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683452425
Hi, I still disagree. We have many classes in the build that are Groovy, based (like the javadocs task). Wht's the difference to that on, just because it's written in Java. If that's the case, I'd copypaste Robert's code into the render-javadocs.gradle file (as the syntax of Java is mostly the same with Gradle). It also now produces Javadocs, it appears in documentation index, it produces artifacts,... It would really be easier if it would be part of the regular build infrastructure in build-src. I know from Elasticserach that they also run forbiddenapis checks there. Just declare and apply the plugin and add one snippet to enable forbiddenapis for this one. I also don't like it to be not separated from the rest of the build. It's purely a build tool, so it should be in build-src or the grade subdirectory. Last but not least: It should not be below "lucene", as it will be useful for Solr, too (after split of projects). So please revert this commit, I disagree here. Maybe @rmuir has similar opinons. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
