rmuir commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683413964
Thanks @dweiss @uschindler @mocobeta please, make any changes if you have the time and motiviation. I agree with the suggestions: plumbing the correct inputs sounds great to make it easier to fix the problems (no need to run clean). As far as how it is organized or how problems are fixed, it doesn't really matter to me, I was just trying to get things working. It is true i took a somewhat risky approach to make some things private. If someone really wants a class to be public they could at least have a one-liner describing what it does. So alternatively these classes could stay public but get some documentation (it means doing real work though) I added the missing `@Override`s because I use the presence of the annotation as a proxy to determine that a method is overridden (and that java will be copied). Maybe it is not theoretically the best way, but it was simple and there was a lot to fix here. I know at least the ECJ compiler has the option to enforce that `@Override` is always there, maybe we should turn that on too separately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
