noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which placement plugin to use What is wrong with hard coding? >t's easy to have a single PropertyValue interface with all possible getter methods and have all but one return an empty optional. Easy ? The whole code looks pretty bad with a million properties and factories. This looks like we are building a J2EE project. Let's make life simple IMHO, you have made this like EJBs . I do not want this PR to be merged in the current form and torment our users ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
