dweiss commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683402017
This looks really good already! My personal preference would be to keep the processing options inside the render javadoc file, rather than pushing them down to each project's build.gradle but it can definitely wait. Other than that I kept wondering if this should piggyback public/private scope changes to classes. Those weight classes in particular - making them private will have side-effects for other code (that may be doing an instanceof, for example). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
